Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable/bttest): fix locking bug in DropRowRange #4200

Closed
wants to merge 1 commit into from

Commits on Jun 2, 2021

  1. fix(bigtable/bttest): fix locking bug in DropRowRange

    DropRowRange's locking is inconsistent with the rest of bttest
    googleapis#2600
    
    ModifyColumnFamilies demonstrates the correct pattern:
    - Use the server global mutex to reference the table by name
    - Use the table's mutex to guard data reads and writes.
    
    The existing implementation can data race if another concurrently running method (such as SampleRowKeys)
    has already dropped the server mutex and acquired the table mutex.  Nothing then prevents DropRowRange
    from mutating table data during a Sample or Scan.
    dragonsinth committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    9755f5a View commit details
    Browse the repository at this point in the history