test(bigtable): switch to cmp for comparison #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
For context my addition of EncryptionInfo, #3899, added a pointer to EncryptionInfo, which caused tests that compare values returned from listbackups and getbackup directly to fail. As the pointers are different, that failed. This method will allow our tests to compare values, not pointer addr. |
crwilcox
approved these changes
May 3, 2021
kolea2
changed the title
tritone
approved these changes
May 3, 2021
codyoss
requested changes
May 3, 2021
…into fix-backup-equal
kolea2
changed the title
codyoss
approved these changes
May 3, 2021
crwilcox
approved these changes
May 3, 2021
kolea2
added
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.