Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): generate GAPIC under internal subdir #4018

Merged
merged 11 commits into from Jun 29, 2021
8 changes: 8 additions & 0 deletions internal/gapicgen/generator/config.go
Expand Up @@ -1204,4 +1204,12 @@ var microgenGapicConfigs = []*microgenConfig{
// GA after 2021/06/10
releaseLevel: "beta",
},
{
inputDirectoryPath: "google/storage/v1",
pkg: "storage",
importPath: "cloud.google.com/go/storage/internal/apiv1",
gRPCServiceConfigPath: "google/storage/v1/storage_grpc_service_config.json",
apiServiceConfigPath: "google/storage/v1/storage_v1.yaml",
releaseLevel: "alpha",
},
}
5 changes: 3 additions & 2 deletions internal/gapicgen/generator/config_test.go
Expand Up @@ -33,8 +33,9 @@ var apivExceptions = map[string]bool{
}

var packagePathExceptions = map[string]bool{
"cloud.google.com/go/longrunning/autogen": true,
"cloud.google.com/go/firestore/apiv1/admin": true,
"cloud.google.com/go/longrunning/autogen": true,
"cloud.google.com/go/firestore/apiv1/admin": true,
"cloud.google.com/go/storage/internal/apiv1": true,
}

// TestMicrogenConfigs validates config entries.
Expand Down
120 changes: 120 additions & 0 deletions storage/internal/apiv1/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.