firestore, datastore: make DetectProjectID work with the emulator #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
broady
force-pushed
the
firestore-emulator
branch
2 times, most recently
from
43f3855
to
5cad77d
Compare
We can use any project ID when the emulator is being used. Try to look detect a real-looking one, and fallback to a dummy ID. Fixes #1751.
broady
force-pushed
the
firestore-emulator
branch
from
5cad77d
to
04bac27
Compare
broady
changed the title
tritone
reviewed
Jul 15, 2020
There was a problem hiding this comment.
Looks good to me! @BenWhitehead could you take a quick look as well?
tritone
approved these changes
Jul 15, 2020
|
I wonder if this is something that we should be implementing at a higher level in the cloud.google.com/go module? The detect logic that is. Right now firestore and datastore both do this. The intent was to support this detection in all of the manual layers looking at #1294. There were a handful of CLs that got closed out when we migrated to GitHub. It would be nice if all of our clients honored the same rules with this detection strategy. |
codyoss
added
do not merge
|
Discussed offline with @codyoss -- we are going to merge this change for now to resolve the immediate issue, and follow up on consistency in projectID detection later |
codyoss
approved these changes
Jul 29, 2020
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 25, 2020
…pis#2598) We can use any project ID when the emulator is being used. Try to look detect a real-looking one, and fallback to a dummy ID. Fixes googleapis#1751. Co-authored-by: Chris Cotter <cjcotter@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use any project ID when the emulator is being used.
Try to look detect a real-looking one, and fallback to a dummy ID.
Fixes #1751.