test(bigtable): Skipping long running tests in short mode #10029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
noahdietz
approved these changes
Apr 29, 2024
cindy-peng
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short mode i.e. presubmit, TestIntegration_* tests are run against Cloud Bigtable emulator.
Cloud Bigtable emulator is intended to help developers use Bigtable for local development and testing, not for production deployments. So, IMO stress testing is not required against the emulator.
TestIntegration_LargeReadsWritesAndScans takes about 81s to 100s to run. Skipping it in presubmit tests.
TestIntegration_LargeReadsWritesAndScans uses the following functions table.Apply, table.ApplyBulk, table.ReadRow, table.ReadRows. These are already being tested in other functions in short mode