Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix apidiff handling of empty set #6912

Merged
merged 19 commits into from Oct 24, 2022

Conversation

noahdietz
Copy link
Contributor

apidiff was silently failing when there were no directories worth diffing. This didn't show up on PR status checks, but shows up in the Action history.

@noahdietz noahdietz requested a review from a team as a code owner October 24, 2022 17:54
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 24, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 24, 2022
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2022
@noahdietz noahdietz merged commit f170284 into googleapis:main Oct 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2022
@noahdietz noahdietz deleted the fix-apidiff branch October 24, 2022 23:52
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants