Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): unflake PublicAccessPrevention test #4352

Merged
merged 2 commits into from Jul 1, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jun 30, 2021

This needs a retry to account for propagation time for bucket
ACLs.

Fixes #4351

This needs a retry to account for propagation time for bucket
ACLs
@tritone tritone requested a review from a team June 30, 2021 15:28
@tritone tritone requested a review from a team as a code owner June 30, 2021 15:28
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2021
Copy link

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Jul 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 58d4055 into googleapis:master Jul 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 1, 2021
@tritone tritone deleted the pap-fix branch July 2, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: TestIntegration_PublicAccessPrevention failed
2 participants