chore(storage): generate GAPIC under internal subdir #4018
Conversation
google-cla
bot
added
the
cla: yes
noahdietz
force-pushed
the
gcs-gapic-poc
branch
from
c81ea03
to
5fd2f07
Compare
noahdietz
force-pushed
the
gcs-gapic-poc
branch
from
5fd2f07
to
3127900
Compare
noahdietz
force-pushed
the
gcs-gapic-poc
branch
2 times, most recently
from
b1353a9
to
0b47db8
Compare
noahdietz
changed the title
|
|
||
| // CallOptions contains the retry settings for each method of Client. | ||
| type CallOptions struct { | ||
| DeleteBucketAccessControl []gax.CallOption |
There was a problem hiding this comment.
I assume it's fine to include everything in the surface (not just media ops) because we are keeping this under internal?
There was a problem hiding this comment.
it's fine to include everything in the surface...because we are keeping this under internal
Yep! Also, the generator doesn't support generating bits of a proto :)
| gax.WithRetry(func() gax.Retryer { | ||
| return gax.OnCodes([]codes.Code{ | ||
| codes.DeadlineExceeded, | ||
| codes.Unavailable, |
There was a problem hiding this comment.
Are these retryers all just entirely defaults, or are they defined in service proto?
There was a problem hiding this comment.
They are defined in the grpc_service_config.json in googleapis by the AP team.
They are pretty basic. And retry doesn't apply to streaming methods after the stream has been created (i.e. resumption).
| return c.internalClient.GetObjectMedia(ctx, req, opts...) | ||
| } | ||
|
|
||
| // InsertObject stores a new object and metadata. |
There was a problem hiding this comment.
Nice detailed docs here, has this been updated at all based on your investigations into resumable uploads @noahdietz ?
There was a problem hiding this comment.
has this been updated at all based on your investigations into resumable uploads
Nope, this is actually just the documentation from the proto itself! I agree, its quite solid.
| _ = c | ||
| } | ||
|
|
||
| func ExampleClient_DeleteBucketAccessControl() { |
There was a problem hiding this comment.
Out of curiosity, have these examples actually proven useful and/or been published in docs for any product?
There was a problem hiding this comment.
They GoDoc examples so they are included in the package examples and with each method doc. I'm not sure if they've been determined useful, but they seem like table stakes for having GoDoc documentation imo.
The snippetgen project generates stuff for the cloud site and tbp@ would be your PoC there.
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Add a gRPC Go GAPIC for the Storage API under an internal subdirectory of the submodule to ensure no one can import it.
This GAPIC is being added for proof of concept development and should not be used in production or by any other client library.
Generated with the following: