Skip to content

Commit

Permalink
feat(logging)!: increase DefaultEntryByteThreshold to 8Mb (#4247)
Browse files Browse the repository at this point in the history
Fixes: #3823 

DefaultEntryByteThreshold = `1 << 20 // 1MiB` ===> `1 << 23 // 8MiB` since size of an entries.write request	can be up to 10 MB. 

`DefaultBufferedByteLimit` is unchanged as that's more a cap on memory utilization.
  • Loading branch information
0xSage committed Jun 29, 2021
1 parent b9081c3 commit f32dd72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion logging/logging.go
Expand Up @@ -75,7 +75,7 @@ const (
DefaultEntryCountThreshold = 1000

// DefaultEntryByteThreshold is the default value for the EntryByteThreshold LoggerOption.
DefaultEntryByteThreshold = 1 << 20 // 1MiB
DefaultEntryByteThreshold = 1 << 23 // 8MiB

// DefaultBufferedByteLimit is the default value for the BufferedByteLimit LoggerOption.
DefaultBufferedByteLimit = 1 << 30 // 1GiB
Expand Down

0 comments on commit f32dd72

Please sign in to comment.