fix(spanner/spansql): fix invalid timestamp literal formats (#6077)

Co-authored-by: rahul2393 <rahulyadavsep92@gmail.com>
googleapis · May 24, 2022 · 6ab8bed · 6ab8bed
1 parent e823d8f
commit 6ab8bed
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/spanner/spansql/parser.go b/spanner/spansql/parser.go
@@ -3113,8 +3113,8 @@ var timestampFormats = []string{
 	"2006-01-02",
 	"2006-01-02 15:04:05",
 	"2006-01-02 15:04:05.000000",
-	"2006-01-02 15:04:05 -07:00",
-	"2006-01-02 15:04:05.000000 -07:00",
+	"2006-01-02 15:04:05-07:00",
+	"2006-01-02 15:04:05.000000-07:00",
 }
 
 var defaultLocation = func() *time.Location {

diff --git a/spanner/spansql/sql.go b/spanner/spansql/sql.go
@@ -736,7 +736,7 @@ func (dl DateLiteral) addSQL(sb *strings.Builder) {
 
 func (tl TimestampLiteral) SQL() string { return buildSQL(tl) }
 func (tl TimestampLiteral) addSQL(sb *strings.Builder) {
-	fmt.Fprintf(sb, "TIMESTAMP '%s'", time.Time(tl).Format("2006-01-02 15:04:05.000000 -07:00"))
+	fmt.Fprintf(sb, "TIMESTAMP '%s'", time.Time(tl).Format("2006-01-02 15:04:05.000000-07:00"))
 }
 
 func (jl JSONLiteral) SQL() string { return buildSQL(jl) }

diff --git a/spanner/spansql/sql_test.go b/spanner/spansql/sql_test.go
@@ -556,7 +556,7 @@ func TestSQL(t *testing.T) {
 		},
 		{
 			TimestampLiteral(time.Date(2014, time.September, 27, 12, 34, 56, 123456e3, latz)),
-			`TIMESTAMP '2014-09-27 12:34:56.123456 -07:00'`,
+			`TIMESTAMP '2014-09-27 12:34:56.123456-07:00'`,
 			reparseExpr,
 		},
 		{