Skip to content

Commit

Permalink
test(datastore): uncomments in, not-in, and != tests (#6728)
Browse files Browse the repository at this point in the history
Fixes #6184
  • Loading branch information
Eric Schmidt committed Sep 23, 2022
1 parent b85dfd9 commit 0ffce1d
Showing 1 changed file with 18 additions and 20 deletions.
38 changes: 18 additions & 20 deletions datastore/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -482,26 +482,24 @@ func TestIntegration_Filters(t *testing.T) {
1,
4,
},
// TODO(#6184): Uncomment the following test cases once test DB is updated.
/*
{
"I!=191",
baseQuery.FilterField("I", "!=", 191),
8,
28,
},
{
"I in {2, 4}",
baseQuery.FilterField("I", "in", []interface{}{2, 4}),
2,
6,
},
{
"I not in {1, 3, 5, 7}",
baseQuery.FilterField("I", "not-in", []interface{}{1, 3, 5, 7}),
4,
12,
}*/
{
"I!=191",
baseQuery.FilterField("I", "!=", 191),
8,
28,
},
{
"I in {2, 4}",
baseQuery.FilterField("I", "in", []interface{}{2, 4}),
2,
6,
},
{
"I not in {1, 3, 5, 7}",
baseQuery.FilterField("I", "not-in", []interface{}{1, 3, 5, 7}),
4,
12,
},
}, func() {
got := []*SQChild{}
want := []*SQChild{
Expand Down

0 comments on commit 0ffce1d

Please sign in to comment.