chore: Update libraries to target netstandard2.0 where feasible #12240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't target netstandard2.0 when the project has a dependency on another project that hasn't already been released with a netstandard2.0 target. This also affects smoke testing etc.
We never use this any more - we just do batch releases, which are smarter (in terms of ignoring chore commits where appropriate etc)
…levant commits This will allow us to easily release APIs where the only feature is changing target frameworks. (This was a problem for ShowStaleCommand, which didn't know about ignoring chore commits etc.)
- Update all mixin dependencies - Use defaults for GAX and common protos - Update manually-specified target frameworks to netstandard2.0 where feasible - Update patch versions to next-minor-version-beta00 (as we intend to release a minor version soon) Currently, Google.Cloud.Spanner.Data still targets netstandard2.1 instead of netstandard2.0, as there are some aspects of ADO.NET which changed in netstandard2.1. We might decide to target both netstandard2.0 *and* netstandard2.1 in the future.
This allows libraries targeting netstandard2.0 to depend on this library.
These are dependency updates for APIs which have not changed target framework.
amanda-tarafa
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ever, review one commit at a time.
In this case, it's worth reviewing the last two commits even though they're autogenerated. The "feat" one should only contain prod projects where the target has changed (as well as some test projects). The "chore" commit should not contain any target changes.
Once this PR is merged, I'll run a batch release which should pick up all the libraries which have changed targets - we'll need to manually move to a new minor for previously-patch-released libraries.
After that, we can change or remove the temporary hack, as there should be very few libraries left which can't target netstandard2.0. (Mostly those targeting Logging.V2 I suspect, as that's a particularly long dependency chain due to Logging.Type.)