Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for PHP 7.4 #2562

Merged
merged 5 commits into from
May 17, 2024
Merged

chore: drop support for PHP 7.4 #2562

merged 5 commits into from
May 17, 2024

Conversation

bshaffer
Copy link
Contributor

No description provided.

@bshaffer bshaffer requested a review from a team as a code owner February 20, 2024 18:36
@Hectorhammett
Copy link
Contributor

The 7.X tests are still running, Should we remove them? What is the protocol here @bshaffer

@vishwarajanand
Copy link
Contributor

README also needs to be changed:

* [PHP 7.4 or higher](https://www.php.net/)

@vishwarajanand
Copy link
Contributor

@Hectorhammett that is happening because php7.4 is mentioned in the repo settings. It can be fixed by removing it, but only admin can see/do this change.

Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@bshaffer bshaffer enabled auto-merge (squash) May 17, 2024 16:05
@bshaffer bshaffer merged commit dae35df into main May 17, 2024
11 checks passed
@bshaffer bshaffer deleted the drop-php74 branch May 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants