Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport): de-experiment google-c2p resolver #1757

Merged
merged 2 commits into from Nov 23, 2022
Merged

feat(transport): de-experiment google-c2p resolver #1757

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4755c89
feat(transport): de-experiment google-c2p resolver
mohanli-ml Nov 21, 2022
959d120
Merge branch 'main' into deexperiment-xds
codyoss Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions transport/grpc/dial.go
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@ func dial(ctx context.Context, insecure bool, o *internal.DialSettings) (*grpc.C
if strings.EqualFold(os.Getenv(enableDirectPathXds), "true") {
// google-c2p resolver target must not have a port number
if addr, _, err := net.SplitHostPort(endpoint); err == nil {
endpoint = "google-c2p-experimental:///" + addr
endpoint = "google-c2p:///" + addr
} else {
endpoint = "google-c2p-experimental:///" + endpoint
endpoint = "google-c2p:///" + endpoint
}
} else {
if !strings.HasPrefix(endpoint, "dns:///") {
Expand Down