fix(option): Having both a TokenSource and Scopes should fail validation #1666
Conversation
There was a problem hiding this comment.
Although I think is a good change to make, it can't be made just yet. We will first need to audit our libraries to ensure we are not passing scopes via the WithScopes client option. I know where are in clients in this repo and may still have places where this is done in our sister repo as well. Adding this check would cause people to never be able to pass the TokenSource option right now in these instances.
I also due worry thinking more about this that there may be libraries built on libraries where these options are passed today. Once we have a better logging solution in place it may be better to log a warning in cases like this. I will need to think about this a little more.
Clarify that when both WithScopes and WithTokenSource are used, the scope settings will be taken from the token source and the WithScopes option will be ignored. Fixes googleapis#1644
|
It was decided that returning an error is unnecessary and that simply clarifying the behavior in the docs will suffice. |
If both ds.TokenSource and ds.Scopes are set, then an error will be returned as Scopes will be ignored
Fixes #1644