Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/gensupport): check ctx in chunk retry #1364

Merged
merged 2 commits into from Jan 6, 2022
Merged

fix(internal/gensupport): check ctx in chunk retry #1364

merged 2 commits into from Jan 6, 2022

Commits on Dec 22, 2021

  1. fix(internal/gensupport): check ctx in chunk retry 

    The select statement is non-deterministic, so currently, if the
pause is completed and ALSO the context has been canceled or
timeout elapsed, a request may still occur. This PR prevents that
circumstance from occurring.

Also removed something in a test that seems to be a workaround for
the race condition.

Inspired by googleapis#1359 & googleapis#1358.
    @tritone
    tritone committed Dec 22, 2021
    Copy the full SHA
    d9aaf01 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Merge branch 'main' into timeout-error-chunk

    @tritone
    tritone committed Jan 6, 2022
    Copy the full SHA
    0594692 View commit details
    Browse the repository at this point in the history