Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/gensupport): Make SendRequestWithRetry check for canceled contexts twice #1359

Merged
merged 4 commits into from Dec 21, 2021
Merged

fix(internal/gensupport): Make SendRequestWithRetry check for canceled contexts twice #1359

merged 4 commits into from Dec 21, 2021

Commits on Dec 21, 2021

  1. fix: Make SendRequestWithRetry check for canceled contexts twice 

    This change makes it deterministic to call SendRequestWithRetry with a
canceled context. This is going to be useful because some Cloud APIs
rely on the context being canceled to prevent some operations from
proceeding, like
[`storage.(*ObjectHandle).NewWriter`](https://pkg.go.dev/cloud.google.com/go/storage#ObjectHandle.NewWriter).

Fixes: googleapis#1358
    @lhchavez
    lhchavez committed Dec 21, 2021
    Copy the full SHA
    091b7c6 View commit details
    Browse the repository at this point in the history

  2. ctx.Err() is idempotent, let's use it instead

    @lhchavez
    lhchavez committed Dec 21, 2021
    Copy the full SHA
    b873c74 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-spurious-send-request-with-write-calls

    @tritone
    tritone committed Dec 21, 2021
    Copy the full SHA
    051a773 View commit details
    Browse the repository at this point in the history

  4. Tidy up those mods 

    Unsure why `go get` didn't to it by itself :/
    @lhchavez
    lhchavez committed Dec 21, 2021
    Copy the full SHA
    b61f9b5 View commit details
    Browse the repository at this point in the history