Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: start reporting a meaningful version in headers #1275

Closed
wants to merge 1 commit into from
Closed

fix: start reporting a meaningful version in headers #1275

wants to merge 1 commit into from

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Oct 28, 2021

No description provided.

@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2021
@codyoss codyoss requested review from yoshi-approver and a team as code owners October 28, 2021 20:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2021
@codyoss
Copy link
Member Author

codyoss commented Oct 28, 2021

This is waiting on googleapis/release-please#1089 to be merged and deployed. After that version.go should be manually corrected and we should regenerate all cached files.

@codyoss
Copy link
Member Author

codyoss commented Jan 14, 2022

This is waiting for v3 of the action to fix a couple of bugs first.

@codyoss
Copy link
Member Author

codyoss commented Feb 8, 2022

Close in favor of #1426

@codyoss codyoss closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codyoss @noahdietz