feat(transport): Use NewComputeEngineCredsWithOptions to replace NewComputeEngineCredentials
#1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
codyoss
requested changes
Sep 14, 2021
transport/grpc/dial.go
Outdated
| @@ -144,7 +144,7 @@ func dial(ctx context.Context, insecure bool, o *internal.DialSettings) (*grpc.C | |||
| } | |||
| grpcOpts = []grpc.DialOption{ | |||
| grpc.WithCredentialsBundle( | |||
| grpcgoogle.NewComputeEngineCredentials(), | |||
| grpcgoogle.NewComputeEngineCredentials(oauth.TokenSource{creds.TokenSource}), | |||
There was a problem hiding this comment.
This code does not compile, this method does not take any arguments.
There was a problem hiding this comment.
Yes we will need to wait for grpc/grpc-go#4767. You may want to add a do not merge label for now.
mohanli-ml
changed the title
NewDirectPathCredentials to replace NewComputeEngineCredentials
codyoss
added
the
do not merge
mohanli-ml
changed the title
NewDirectPathCredentials to replace NewComputeEngineCredentialsNewComputeEngineCredsWithPerRPC to replace NewComputeEngineCredentials
…mputeEngineCredentials
mohanli-ml
changed the title
NewComputeEngineCredsWithPerRPC to replace NewComputeEngineCredentialsNewComputeEngineCredsWithOptions to replace NewComputeEngineCredentials
…omputeEngineCredentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a new API
NewDirectPathCredentialsinstead ofNewComputeEngineCredentials. See context in grpc-go: grpc/grpc-go#4767.