Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bulk alias rest of cloud APIs #948

Closed
wants to merge 1 commit into from

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 1, 2022

No description provided.

@codyoss codyoss requested a review from a team as a code owner December 1, 2022 22:41
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 1, 2022
@codyoss
Copy link
Member Author

codyoss commented Dec 1, 2022

Need to look closer at bigquery flagging.

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 1, 2022
@codyoss
Copy link
Member Author

codyoss commented Dec 1, 2022

The reason for the breaking change here is do to the fact our current automation retains files when they are deleted from googleapis. The sources here that were "removed" actually were removed about 3 years ago from googleapis: googleapis/googleapis@e47fdd2

These message types are unused and are not apart of the public api. Actually since they were removed it looks like similar types were really added to the proper v1 client later. For example: https://cloud.google.com/bigquery/docs/reference/datatransfer/rpc/google.cloud.bigquery.datatransfer.v1#google.cloud.bigquery.datatransfer.v1.DataSource

I believe this should be fine to merge.

@codyoss
Copy link
Member Author

codyoss commented Dec 2, 2022

Will regen this one new after googleapis/google-cloud-go#7117 is merged and released

@codyoss codyoss closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant