Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node-fetch to ^2.6.5 #439

Merged
merged 1 commit into from Sep 24, 2021

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

There was an issue with query parameters in node-fetch version 2.6.3. See node-fetch/node-fetch#1301. The node-js storage library had a few people raising the issue (googleapis/nodejs-storage#1600). I would like to update node-fetch to ^2.6.5 to avoid the bad version of node-fetch.

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner September 24, 2021 16:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2021
@bcoe bcoe merged commit a9f4138 into googleapis:main Sep 24, 2021
@ddelgrosso1 ddelgrosso1 deleted the update-node-fetch branch September 24, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants