Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax rake version dependency #358

Merged
merged 2 commits into from Mar 9, 2020
Merged

fix: relax rake version dependency #358

merged 2 commits into from Mar 9, 2020

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Mar 9, 2020

Because we've relaxed the rake version in the other libraries in google-cloud-ruby (see googleapis/google-cloud-ruby#4897)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2020
@dazuma dazuma requested a review from a team March 9, 2020 17:47
viacheslav-rostovtsev
viacheslav-rostovtsev approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

quartzmo
quartzmo approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the google-cloud-ruby PR completely removed the dependency spec (rather than changing it to >= 12.0). Was that a mistake?

@dazuma
Copy link
Member Author

dazuma commented Mar 9, 2020

@quartzmo I think it's better to provide a minimum, though I don't think it really matters that much.

@dazuma dazuma merged commit a97f9a6 into googleapis:master Mar 9, 2020
@dazuma dazuma deleted the rake-version branch March 9, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@viacheslav-rostovtsev viacheslav-rostovtsev viacheslav-rostovtsev approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dazuma @quartzmo @viacheslav-rostovtsev @googlebot