Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gapic: support EnableJwtWithScope for gRPC GAPIC clients #674

Merged
merged 4 commits into from Jun 23, 2021

Conversation

shinfan
Copy link
Contributor

@shinfan shinfan commented Jun 22, 2021

@shinfan shinfan requested review from a team as code owners June 22, 2021 23:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@shinfan
Copy link
Contributor Author

shinfan commented Jun 22, 2021

cc @codyoss @silvolu @bshaffer

@noahdietz
Copy link
Collaborator

googleapis/google-api-go-client#1075 needs to be released and we might need to update the version of google.golang.org/api used in the showcase integration test submodule. The integration tests do not compile atm because of this.

LGTM otherwise

@shinfan
Copy link
Contributor Author

shinfan commented Jun 22, 2021

LGTM otherwise

Thanks Noah. I will fix the dependency issue once it is released.

@codyoss
Copy link
Member

codyoss commented Jun 23, 2021

Released: https://github.com/googleapis/google-api-go-client/releases/tag/v0.49.0

@shinfan shinfan changed the title Support EnableJwtWithScope for gRPC GAPIC clients feat: support EnableJwtWithScope for gRPC GAPIC clients Jun 23, 2021
@shinfan
Copy link
Contributor Author

shinfan commented Jun 23, 2021

@noahdietz PTAL

internal/gengapic/log Outdated Show resolved Hide resolved
@noahdietz noahdietz changed the title feat: support EnableJwtWithScope for gRPC GAPIC clients gapic: support EnableJwtWithScope for gRPC GAPIC clients Jun 23, 2021
@noahdietz noahdietz added the automerge Summon MOG for automerging label Jun 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f6bebb1 into googleapis:master Jun 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants