New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gapic: support EnableJwtWithScope for gRPC GAPIC clients #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shinfan
commented
Jun 22, 2021
•
edited
edited
- Update the GAPIC clients to allow scope for self-signed JWT
- The self-signed JWT is now the default authentication method for service account instead of OAuth 2.0
- Self-signed JWT AIP: https://google.aip.dev/auth/4111
- Related PRs:
- feat(internal): [AIP-4111] support scopes for self-signed JWT auth flow google-api-go-client#1075
- google: support scopes for JWT access token golang/oauth2#504
- 4110: Update ADC with support for self-signed JWT aip-dev/google.aip.dev#764
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 22, 2021
googleapis/google-api-go-client#1075 needs to be released and we might need to update the version of google.golang.org/api used in the LGTM otherwise |
Thanks Noah. I will fix the dependency issue once it is released. |
shinfan
changed the title
Support EnableJwtWithScope for gRPC GAPIC clients
feat: support EnableJwtWithScope for gRPC GAPIC clients
Jun 23, 2021
@noahdietz PTAL |
noahdietz
reviewed
Jun 23, 2021
noahdietz
changed the title
feat: support EnableJwtWithScope for gRPC GAPIC clients
gapic: support EnableJwtWithScope for gRPC GAPIC clients
Jun 23, 2021
noahdietz
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.