-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lro method settings #779
base: main
Are you sure you want to change the base?
Lro method settings #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this looks good.
@@ -1,4 +1,4 @@ | |||
// Copyright 2019 Google LLC | |||
// Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: undo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do - this was just the result of copying the generated file into place :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK then, don't, else it will always show up.
@@ -27,6 +27,15 @@ service Lro { | |||
}; | |||
option (google.api.method_signature) = "name"; | |||
} | |||
|
|||
// Test an LRO RPC with customized default polling settings. | |||
rpc CustomDefaultPollingMethod(Request) returns(google.longrunning.Operation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just a test method, but the combination of custom and default is always very confusing to me. Can you use default override instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe PublishingSettingsPollingMethod? ServiceConfigPollingMethod? Happy to bike shed this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, any one of those is fine as well. Whatever you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny ping on this one.
@@ -1,4 +1,4 @@ | |||
// Copyright 2019 Google LLC | |||
// Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK then, don't, else it will always show up.
@@ -27,6 +27,15 @@ service Lro { | |||
}; | |||
option (google.api.method_signature) = "name"; | |||
} | |||
|
|||
// Test an LRO RPC with customized default polling settings. | |||
rpc CustomDefaultPollingMethod(Request) returns(google.longrunning.Operation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, any one of those is fine as well. Whatever you prefer.
Generation has completed - it would lead to no changes in google-cloud-dotnet. |
1d24ec9
to
570279c
Compare
I'm going to pull the first commit from here into a separate PR so we can keep this PR as "just the new feature". |
This currently just uses the default poll settings, so shouldn't affect the generated code at all. (This is the first step to using the settings from the service config.)
(This is specified in publishing settings, but feels like it's more LRO-oriented than settings-oriented.)
…RO method (This is to make the diff for "with the feature" simpler to understand.)
(This includes the change in generated code, as it's so small.)
570279c
to
566bb09
Compare
@@ -27,6 +27,15 @@ service Lro { | |||
}; | |||
option (google.api.method_signature) = "name"; | |||
} | |||
|
|||
// Test an LRO RPC with customized default polling settings. | |||
rpc CustomDefaultPollingMethod(Request) returns(google.longrunning.Operation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny ping on this one.
Will have a look tomorrow. I'm not actually in a hurry to get this in, but I wanted it in a better shape :) |
Fixes #557.
I'm going to run this locally against all APIs to see whether we get any changes - I don't expect there to be any settings configured in MethodSettings yet. (They're all in _gapic.yaml files.)
We should then discuss what we want to do.