Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LRO polling generation configurable #557

Closed
jskeet opened this issue Oct 31, 2022 · 2 comments · May be fixed by #779
Closed

Make LRO polling generation configurable #557

jskeet opened this issue Oct 31, 2022 · 2 comments · May be fixed by #779
Assignees
@jskeet
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jskeet
Copy link
Collaborator

jskeet commented Oct 31, 2022

We currently use a hard-coded set of LRO polling options.

There is configuration for LRO polling, but it's in GAPIC YAML files which we don't currently use for anything else. Given the lack of customer feedback on this, we can probably leave this for now - but we should try to rationalize where our configuration comes from, and then include LRO polling in that.
@jskeet jskeet added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 31, 2022
@jskeet jskeet self-assigned this Oct 31, 2022
@jskeet
Copy link
Collaborator Author

jskeet commented Apr 4, 2024

There are now LRO settings within MethodSettings. Will prototype using those from the GAPIC generator - it should be pretty straightforward.

@jskeet jskeet mentioned this issue Apr 4, 2024
Open
@jskeet
Copy link
Collaborator Author

jskeet commented Apr 16, 2024

Closing as we're tracking this internally.

@jskeet jskeet closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lro method settings jskeet/gapic-generator-csharp
1 participant
@jskeet