Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redirect some test output to serial port 3 #453

Merged
merged 1 commit into from Apr 2, 2019

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented Apr 1, 2019

TESTED: Confirmed output from nvm install for presubmit system test appeared in GCP logging console.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2019
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #453 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #453   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           4        4           
  Lines         212      212           
  Branches       24       24           
=======================================
  Hits          161      161           
  Misses         48       48           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ab235...e70172f. Read the comment docs.

@nolanmar511 nolanmar511 changed the title DO NOT REVIEW chore: redirect some test output to serial port 3 chore: redirect some test output to serial port 3 Apr 2, 2019
@aalexand
Copy link
Contributor

aalexand commented Apr 2, 2019

npm audit reports the error below, should it be fixed?

#!/bin/bash -eo pipefail
npm audit
=== npm audit security report ===                        
                                                                                
                                                                                
                                 Manual Review                                  
             Some vulnerabilities require your attention to resolve             
                                                                                
          Visit https://go.npm.me/audit-guide for additional guidance           
                                                                                
                                                                                
  Moderate        Denial of Service                                             
                                                                                
  Package         js-yaml                                                       
                                                                                
  Patched in      >=3.13.0                                                      
                                                                                
  Dependency of   mocha [dev]                                                   
                                                                                
  Path            mocha > js-yaml                                               
                                                                                
  More info       https://nodesecurity.io/advisories/788                        
                                                                                
found 1 moderate severity vulnerability in 2736 scanned packages
  1 vulnerability requires manual review. See the full report for details.
Exited with code 1

@nolanmar511
Copy link
Contributor Author

npm audit error is not currently fixable. We're waiting for mocha to cut a new release.
mochajs/mocha#3854

@nolanmar511 nolanmar511 merged commit a56b762 into googleapis:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants