Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deriving traits on data-carrying enums #879

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Support deriving traits on data-carrying enums #879

wants to merge 5 commits into from

Conversation

djkoloski
Copy link
Member

@djkoloski djkoloski commented Feb 14, 2024 •
edited

This PR isn't yet complete. Still to do:

  • Write a padding check for data-carrying enums
  • Add support for deriving IntoBytes using the padding check
  • Add support for deriving FromZeros with a custom type check
  • Un-gate support for deriving Unaligned and FromBytes
  • Write tests for data-carrying enums
  • Justify new unsafe blocks in derived impls

@djkoloski djkoloski force-pushed the data_carrying_enum_support branch 2 times, most recently from 8ecf6d8 to 5b8ead9 Compare February 14, 2024 17:43
@djkoloski djkoloski changed the title Support deriving TryFromBytes on data-carrying enums Support deriving traits on data-carrying enums Feb 15, 2024
@joshlf joshlf mentioned this pull request Feb 17, 2024
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@djkoloski