Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add details on how to run generated code #363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

cglotr
Copy link

@cglotr cglotr commented Jun 11, 2022

Fixes #362

Added some details on how to run the generated code. I was having a bad time following the tutorial since I kept getting the error:

# command-line-arguments
./main.go:45:11: undefined: InitializeEvent

when following the tutorial since I ran it with go run main.go using go1.18.3. It's not obvious to me that we need to include wire_gen.go to make it work.

@google-cla
Copy link

google-cla bot commented Jun 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@jayzhuang jayzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the title of commit message, please fix, s/to to/how to

@cglotr cglotr changed the title add details on to to run generated code add details on how to run generated code Jun 19, 2022
@cglotr
Copy link
Author

cglotr commented Jun 19, 2022

There's a typo in the title of commit message, please fix, s/to to/how to

@jayzhuang i have changed the commit msg

@cglotr cglotr requested a review from jayzhuang June 19, 2022 14:42
@jayzhuang
Copy link
Collaborator

LGTM

@jayzhuang
Copy link
Collaborator

+@stytchiz who have write access

@stytchiz
Copy link
Collaborator

Thanks @jayzhuang :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing go run or go build example of generated code
3 participants