wire: wire.FieldsOf should not provide pointer to field type for non-pointer structs #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantuo
requested changes
Sep 5, 2019
internal/wire/testdata/FieldsOfStructDoNotProvidePtrToField/foo/wire.go
Outdated
Show resolved
Hide resolved
shantuo
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zombiezen pointed out (hah!) that
FieldsOfshould not provide a pointer to field types in cases where the struct itself is not a pointer; the struct is then a temporary variable.I moved the previously-working "pointer to field type" test from
FieldsOfStructtoFieldsOfStructPointer, and added a new non-working testcase attempting to provide a ptr-to-field from a non-pointer struct (expected to fail).Fixes #208.