wire: FieldsOf now provides a pointer to the field type as well as the actual field type #209
Conversation
… actual field type
|
Please edit the title of this pull request with the name of the affected component, or "all", followed by a colon, followed by a short summary of the change. |
vangent
changed the title
docs/guide.md
Outdated
| @@ -231,12 +231,13 @@ have a provider in the same set that provides the concrete type. | |||
| [type identity]: https://golang.org/ref/spec#Type_identity | |||
| [return concrete types]: https://github.com/golang/go/wiki/CodeReviewComments#interfaces | |||
|
|
|||
| ### Struct Providers | |||
| ### Injected Structs | |||
There was a problem hiding this comment.
I reworded this section a bit; I found it a bit confusing since FieldsOf is really using structs as providers, whereas Struct is injecting a struct. Feedback welcome.
There was a problem hiding this comment.
My understanding of the term "provider" in wire means the "initialization function" that provides a certain type. For wire.Struct, the provider is the generated code that populates the struct, for wire.FieldsOf, the provider is the generated code that returns the asked fields. In this case the title "Struct Providers" looks accurate to me. While one can argue the title below for FieldsOf is confusing, I would change it to something like "Struct Fields Providers" or "Injecting Fields of Structs".
docs/guide.md
Outdated
| @@ -231,12 +231,13 @@ have a provider in the same set that provides the concrete type. | |||
| [type identity]: https://golang.org/ref/spec#Type_identity | |||
| [return concrete types]: https://github.com/golang/go/wiki/CodeReviewComments#interfaces | |||
|
|
|||
| ### Struct Providers | |||
| ### Injected Structs | |||
There was a problem hiding this comment.
My understanding of the term "provider" in wire means the "initialization function" that provides a certain type. For wire.Struct, the provider is the generated code that populates the struct, for wire.FieldsOf, the provider is the generated code that returns the asked fields. In this case the title "Struct Providers" looks accurate to me. While one can argue the title below for FieldsOf is confusing, I would change it to something like "Struct Fields Providers" or "Injecting Fields of Structs".
Fixes #208.