Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadFrom, WriteTo and Max #146

Closed
wants to merge 3 commits into from
Closed

ReadFrom, WriteTo and Max #146

wants to merge 3 commits into from

Conversation

it512
Copy link
Contributor

@it512 it512 commented Dec 12, 2023

add ReadFrom and WriteTo function
add Max UUID

@it512 it512 requested a review from a team as a code owner December 12, 2023 01:28
@it512 it512 mentioned this pull request Dec 12, 2023
Copy link
Collaborator

@bormanp bormanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a justification for adding these two functions. I understand that these implement io.ReaderFrom and io.WriterTo signatures but there needs to be a good reason for these functions such that they "carry their own water" as they say.

@it512
Copy link
Contributor Author

it512 commented Dec 13, 2023

1 UUID作为一种类型,在一些编码和解码场景需要直接的io.Reader和io.Writer和操作,从而减少零时对象的生成,和方便使用
2 在网络编程中,可以直接从net.Conn中读取/写入UUID
~~~~~~~~~~~
1 UUID as a type requires direct io.Reader and io.Writer operations in some encoding and decoding scenarios, thereby reducing the generation of temporary objects and making it easier to use
2 In network programming, you can read/write UUID directly from net.Conn

@it512 it512 closed this Jan 11, 2024
@it512 it512 deleted the bytes_writeto branch January 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants