Updated golangci-lint to latest version, which supports Go v.13 #1815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1815 +/- ##
=======================================
Coverage 59.63% 59.63%
=======================================
Files 110 110
Lines 10336 10336
=======================================
Hits 6164 6164
Misses 3564 3564
Partials 608 608Continue to review full report at Codecov.
|
This removes the transitive dependency on a version of golangci-lint which had a messy go.mod file, which allows the clean up of these requires.
|
Would you mind including the commands that you ran to produce these changes? |
| replace github.com/golangci/lint-1 v0.0.0-20180610141402-ee948d087217 => github.com/golangci/lint-1 v0.0.0-20190420132249-ee948d087217 | ||
|
|
||
| replace mvdan.cc/unparam v0.0.0-20190124213536-fbb59629db34 => mvdan.cc/unparam v0.0.0-20190209190245-fbb59629db34 | ||
|
|
||
| replace google.golang.org/genproto v0.0.0-20170818100345-ee236bd376b0 => google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0 |
There was a problem hiding this comment.
Do you know which dependency has this invalid pseudo-version in their go.mod file?
There was a problem hiding this comment.
github.com/fullstorydev/grpcurl@v1.3.1 requires
github.com/jhump/protoreflect@v1.4.4 requires
google.golang.org/genproto@v0.0.0-20170818100345-ee236bd376b0: invalid pseudo-version: does not match version-control timestamp (2017-08-18T01:03:45Z)
There was a problem hiding this comment.
It looks like that was fixed about a month ago: jhump/protoreflect#258
There was a problem hiding this comment.
I'll upgrade the uber library which has a stale dep. That seems to fix it.
It was non-trivial - I had to edit the file. I can try to reproduce it from a fresh client with pure commands if that exercise has value. I was getting surprising errors though; I think go is at least mildly upset we have a dependency cycle between trillian and certificate-transparency-go. |
…le#1815) * Updated golangci-lint to latest version, which supports Go v.13 * Updated to latest version of certificate-transparency-go and cleaned up This removes the transitive dependency on a version of golangci-lint which had a messy go.mod file, which allows the clean up of these requires.
…le#1815) * Updated golangci-lint to latest version, which supports Go v.13 * Updated to latest version of certificate-transparency-go and cleaned up This removes the transitive dependency on a version of golangci-lint which had a messy go.mod file, which allows the clean up of these requires.
* Updated golangci-lint to latest version, which supports Go v.13 * Updated to latest version of certificate-transparency-go and cleaned up This removes the transitive dependency on a version of golangci-lint which had a messy go.mod file, which allows the clean up of these requires.
When the same fix is applied to certificate-transparency-go this may allow us to remove the require statements at the bottom of the go.mod file.