Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.3.2 #1802

Merged
merged 2 commits into from Sep 5, 2019
Merged

Release v1.3.2 #1802

merged 2 commits into from Sep 5, 2019

Conversation

RJPercival
Copy link
Contributor

@RJPercival RJPercival commented Sep 5, 2019 •
edited

Patch release that just adds the fix in PR #1801 on top of v1.3.1.

Checklist

Rob Percival added 2 commits September 5, 2019 17:30
Fix invalid Go Module pseudo-versions used by dependencies
d260e4e 
Override the invalid pseudo-versions with correct pseudo-versions that
refer to the same commits.
Create patch release v1.3.2
08d71f3 
Contains a fix to invalid pseudo-versions found in the go.mod files of
some of our dependencies. This has been cherry-picked from the master
branch.
@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited

Codecov Report

Merging #1802 into v1.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.3    #1802   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files         110      110           
  Lines       10310    10310           
=======================================
  Hits         6154     6154           
  Misses       3549     3549           
  Partials      607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302b47d...08d71f3. Read the comment docs.

@RJPercival RJPercival merged commit 10ac7e3 into google:v1.3 Sep 5, 2019
@RJPercival
Copy link
Contributor Author

Sadly this didn't have the desired effect because replace directives are ignored when building other modules. Therefore, things that depends on us have to copy those replace directives into their own go.mod files (requiring them to create one if they don't have one already).

@RJPercival
Copy link
Contributor Author

It may be better to remove golangci-lint from tools.go until they've fixed their go.mod file, otherwise we'll continue propagating this problem to anyone that depends on us.

@mhutchinson
Copy link
Contributor

See golangci/golangci-lint#643 - it's blocked at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdbelvin gdbelvin gdbelvin approved these changes

@mhutchinson mhutchinson Awaiting requested review from mhutchinson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RJPercival @mhutchinson @gdbelvin @googlebot