Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Change QEMU args to use multiboot shim. #681

Closed

Conversation

flowerhack
Copy link
Collaborator

No description provided.

@flowerhack flowerhack force-pushed the actually-true-support-multiboot branch from dc41ba6 to e636924 Compare August 15, 2018 00:54
@flowerhack
Copy link
Collaborator Author

So I've formatted these files as you suggested in the other PR, but I'm still getting a presubmit error, and I'm struggling to figure out what's wrong.

It seems to be complaining at the "check diff" step, but I've run generate + format locally and committed all changes, I have an empty diff locally, so I'm not sure what the issue is.

When I run "make presubmit" locally, I don't see an error at check_diff (though I do see a different error, at test_64_fork, that I don't understand either: https://gist.github.com/flowerhack/9c9622f1964ea735e826cd51f7411e58 ).

Is there something I'm missing here? If so, could a message about whatever I'm missing get included in the presubmit check? This isn't the first time I've been perplexed by check_diff's behavior.

@flowerhack
Copy link
Collaborator Author

Resolves #669

@flowerhack
Copy link
Collaborator Author

@dvyukov

@dvyukov
Copy link
Collaborator

dvyukov commented Aug 15, 2018

When I run "make presubmit" locally, I don't see an error at check_diff (though I do see a different error, at test_64_fork, that I don't understand either:

I think it's unrelated to test_64_fork, there are error messages before that:

make[3]: powerpc64le-linux-gnu-gcc: Command not found
make[3]: aarch64-linux-gnu-gcc: Command not found

If you are running it locally, you need to do make install_prerequisites first.

@dvyukov
Copy link
Collaborator

dvyukov commented Aug 15, 2018

Re diffs, I guess you are using go1.11? Unfortunately you need to use go1.9 or 1.10.
Go broke this with no hints of how this can be repaired :(
golang/go#25161
golang/go#26228

@flowerhack
Copy link
Collaborator Author

Closing for #684

@flowerhack flowerhack closed this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants