Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript dependencies #165

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Update TypeScript dependencies #165

merged 2 commits into from
Mar 15, 2022

Conversation

antiphoton
Copy link
Collaborator

@antiphoton antiphoton commented Mar 10, 2022

Closes #161

Note to the second commit in this PR

Object.keys(pkg.dependencies) === [
  'fastify',
  'node-fetch',
  'puppeteer',
]

node-fetch v3 no longer support commonjs (example), hence we need to let rollup to compile node-fetch, by removing node-fetch from the external list.

@antiphoton antiphoton requested a review from banaag March 10, 2022 22:29
@antiphoton antiphoton enabled auto-merge (squash) March 10, 2022 22:30
@antiphoton antiphoton requested review from twifkak and removed request for banaag March 14, 2022 20:08
Copy link
Collaborator

@twifkak twifkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants