Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(build):fix isort version conflicting with newest poetry release #340

Merged
merged 1 commit into from Jun 13, 2023
Merged

Chore(build):fix isort version conflicting with newest poetry release #340

merged 1 commit into from Jun 13, 2023

Conversation

mveroone
Copy link
Contributor

Seems a recent release of poetry broke isort.
Upgrade to at least 5.12.0 is required to fix.

Without this, the pre-commit hook is broken

Related link : https://levelup.gitconnected.com/fix-runtimeerror-poetry-isort-5db7c67b60ff

@mveroone mveroone changed the title Chopre(build):fix isort version conflicting with nexest poetry release Chopre(build):fix isort version conflicting with newest poetry release May 30, 2023
@mveroone mveroone changed the title Chopre(build):fix isort version conflicting with newest poetry release Chore(build):fix isort version conflicting with newest poetry release May 30, 2023
@mveroone mveroone mentioned this pull request May 30, 2023
Merged
@lvaylet
Copy link
Collaborator

lvaylet commented Jun 7, 2023

Hi @mveroone ,

What was the error exactly? We do not rely (yet) on Poetry to manage dependencies so I am a bit surprised by this incompatibility.

I tried to reproduce the issue in a brand new virtual environment. After make install, isort --version returns:

(venv_test) user@workstation-la3rvj4l:~/workspace/github/google/slo-generator$ isort --version

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.12.0

Then make format (which uses isort) and pre-commit seem to work fine:

(venv_test) user@workstation-la3rvj4l:~/workspace/github/google/slo-generator$ make format
isort .
Skipped 6 files
black .
All done! ✨ 🍰 ✨
47 files left unchanged.
(venv_test) user@workstation-la3rvj4l:~/workspace/github/google/slo-generator$ pre-commit
trim trailing whitespace.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
autoflake............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
black................................................(no files to check)Skipped
isort................................................(no files to check)Skipped
pylint...............................................(no files to check)Skipped

@mveroone
Copy link
Contributor Author

mveroone commented Jun 8, 2023 •
edited

Hi.
When running against master I get this :

❯ ./venv/bin/pre-commit run
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/mveroone/.cache/pre-commit/repoa6vlf55_
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-yef1679j/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-yef1679j/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/mveroone/.cache/pre-commit/pre-commit.log

using venv and python 3.9

With this PR, it's fixed :

❯ ./venv/bin/pre-commit run
trim trailing whitespace.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
autoflake............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
black................................................(no files to check)Skipped
isort................................................(no files to check)Skipped
pylint...............................................(no files to check)Skipped
❯ ./venv/bin/pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
autoflake................................................................Passed
flake8...................................................................Passed
black....................................................................Passed
isort....................................................................Passed
pylint...................................................................Passed```

@lvaylet
Copy link
Collaborator

lvaylet commented Jun 9, 2023 •
edited

I just tested the following workflow from a fresh git clone with Python 3.9.15:

cd /tmp
git clone git@github.com:google/slo-generator.git
cd slo-generator/
python3 --version
python3 -m venv venv
source venv/bin/activate
make install
pre-commit run
pre-commit run --all-files
isort --version

Here is the detailed output:

user@workstation-la3rvj4l:~$ cd /tmp
user@workstation-la3rvj4l:/tmp$ git clone git@github.com:google/slo-generator.git
Cloning into 'slo-generator'...
remote: Enumerating objects: 2443, done.
remote: Counting objects: 100% (361/361), done.
remote: Compressing objects: 100% (184/184), done.
remote: Total 2443 (delta 189), reused 329 (delta 175), pack-reused 2082
Receiving objects: 100% (2443/2443), 1.04 MiB | 2.34 MiB/s, done.
Resolving deltas: 100% (1510/1510), done.
user@workstation-la3rvj4l:/tmp$ cd slo-generator/
user@workstation-la3rvj4l:/tmp/slo-generator$ python3 --version
Python 3.9.15
user@workstation-la3rvj4l:/tmp/slo-generator$ python3 -m venv venv
user@workstation-la3rvj4l:/tmp/slo-generator$ source venv/bin/activate
(venv) user@workstation-la3rvj4l:/tmp/slo-generator$ make install
Cleaning up distutils stuff
rm -rf build
rm -rf dist
rm -rf MANIFEST
rm -rf *.egg-info
Cleaning up byte compiled python stuff
find . -type f -regex ".*\.py[co]$" -delete
Cleaning up doc builds
rm -rf docs/_build
rm -rf docs/api_modules
rm -rf docs/client_modules
Cleaning up test reports
rm -rf report/*
pip3 install -e ."[api, datadog, prometheus, elasticsearch, pubsub, cloud_monitoring, bigquery, dev]"
Obtaining file:///tmp/slo-generator
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Collecting python-dateutil
  Using cached python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
Collecting click
  Using cached click-8.1.3-py3-none-any.whl (96 kB)
Collecting ruamel.yaml
  Using cached ruamel.yaml-0.17.31-py3-none-any.whl (112 kB)
Collecting setuptools>=65.5.1
  Using cached setuptools-67.8.0-py3-none-any.whl (1.1 MB)
Collecting pyyaml
  Using cached PyYAML-6.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (661 kB)
Collecting google-api-python-client<2
  Using cached google_api_python_client-1.12.11-py2.py3-none-any.whl (62 kB)
Collecting google-cloud-pubsub<2
  Using cached google_cloud_pubsub-1.7.2-py2.py3-none-any.whl (144 kB)
Collecting prometheus-client
  Using cached prometheus_client-0.17.0-py3-none-any.whl (60 kB)
Collecting prometheus-http-client
  Using cached prometheus_http_client-1.0.0-py2.py3-none-any.whl (21 kB)
Collecting datadog
  Using cached datadog-0.45.0-py2.py3-none-any.whl (113 kB)
Collecting retrying==1.3.3
  Using cached retrying-1.3.3-py3-none-any.whl
Collecting elasticsearch
  Using cached elasticsearch-8.8.0-py3-none-any.whl (393 kB)
Collecting functions-framework
  Using cached functions_framework-3.4.0-py3-none-any.whl (32 kB)
Collecting cloudevents
  Using cached cloudevents-1.9.0-py3-none-any.whl (47 kB)
Collecting requests
  Using cached requests-2.31.0-py3-none-any.whl (62 kB)
Collecting gunicorn
  Using cached gunicorn-20.1.0-py3-none-any.whl (79 kB)
Collecting Flask
  Using cached Flask-2.3.2-py3-none-any.whl (96 kB)
Collecting google-cloud-monitoring<3
  Using cached google_cloud_monitoring-2.15.0-py2.py3-none-any.whl (323 kB)
Collecting pip>=22.3
  Using cached pip-23.1.2-py3-none-any.whl (2.1 MB)
Collecting isort
  Using cached isort-5.12.0-py3-none-any.whl (91 kB)
Collecting types-protobuf
  Using cached types_protobuf-4.23.0.1-py3-none-any.whl (61 kB)
Collecting types-requests
  Using cached types_requests-2.31.0.1-py3-none-any.whl (14 kB)
Collecting wheel
  Using cached wheel-0.40.0-py3-none-any.whl (64 kB)
Collecting black
  Using cached black-23.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.7 MB)
Collecting pytest-cov
  Using cached pytest_cov-4.1.0-py3-none-any.whl (21 kB)
Collecting flake8
  Using cached flake8-6.0.0-py2.py3-none-any.whl (57 kB)
Collecting mock
  Using cached mock-5.0.2-py3-none-any.whl (30 kB)
Collecting pylint
  Using cached pylint-2.17.4-py3-none-any.whl (536 kB)
Collecting pre-commit
  Using cached pre_commit-3.3.2-py2.py3-none-any.whl (202 kB)
Collecting pytype
  Using cached pytype-2023.6.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.9 MB)
Collecting safety
  Using cached safety-2.3.5-py3-none-any.whl (57 kB)
Collecting types-setuptools
  Using cached types_setuptools-67.8.0.0-py3-none-any.whl (44 kB)
Collecting mypy
  Using cached mypy-1.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (12.2 MB)
Collecting types-PyYAML
  Using cached types_PyYAML-6.0.12.10-py3-none-any.whl (14 kB)
Collecting pytest
  Using cached pytest-7.3.1-py3-none-any.whl (320 kB)
Collecting bandit
  Using cached bandit-1.7.5-py3-none-any.whl (123 kB)
Collecting types-python-dateutil
  Using cached types_python_dateutil-2.8.19.13-py3-none-any.whl (9.2 kB)
Collecting google-cloud-bigquery<3
  Using cached google_cloud_bigquery-2.34.4-py2.py3-none-any.whl (206 kB)
Collecting six>=1.7.0
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting google-auth-httplib2>=0.0.3
  Using cached google_auth_httplib2-0.1.0-py2.py3-none-any.whl (9.3 kB)
Collecting uritemplate<4dev,>=3.0.0
  Using cached uritemplate-3.0.1-py2.py3-none-any.whl (15 kB)
Collecting google-auth<3dev,>=1.16.0
  Using cached google_auth-2.19.1-py2.py3-none-any.whl (181 kB)
Collecting google-api-core<3dev,>=1.21.0
  Using cached google_api_core-2.11.0-py3-none-any.whl (120 kB)
Collecting httplib2<1dev,>=0.15.0
  Using cached httplib2-0.22.0-py3-none-any.whl (96 kB)
Collecting proto-plus<2.0.0dev,>=1.15.0
  Using cached proto_plus-1.22.2-py3-none-any.whl (47 kB)
Collecting grpcio<2.0dev,>=1.38.1
  Using cached grpcio-1.54.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.1 MB)
Collecting packaging<22.0dev,>=14.3
  Using cached packaging-21.3-py3-none-any.whl (40 kB)
Collecting protobuf<4.0.0dev,>=3.12.0
  Using cached protobuf-3.20.3-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.0 MB)
Collecting google-cloud-core<3.0.0dev,>=1.4.1
  Using cached google_cloud_core-2.3.2-py2.py3-none-any.whl (29 kB)
Collecting google-resumable-media<3.0dev,>=0.6.0
  Using cached google_resumable_media-2.5.0-py2.py3-none-any.whl (77 kB)
Collecting grpc-google-iam-v1<0.13dev,>=0.12.3
  Using cached grpc_google_iam_v1-0.12.6-py2.py3-none-any.whl (26 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2023.5.7-py3-none-any.whl (156 kB)
Collecting charset-normalizer<4,>=2
  Using cached charset_normalizer-3.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (199 kB)
Collecting urllib3<3,>=1.21.1
  Using cached urllib3-2.0.3-py3-none-any.whl (123 kB)
Collecting idna<4,>=2.5
  Using cached idna-3.4-py3-none-any.whl (61 kB)
Collecting rich
  Using cached rich-13.4.1-py3-none-any.whl (239 kB)
Collecting stevedore>=1.20.0
  Using cached stevedore-5.1.0-py3-none-any.whl (49 kB)
Collecting GitPython>=1.0.1
  Using cached GitPython-3.1.31-py3-none-any.whl (184 kB)
Collecting mypy-extensions>=0.4.3
  Using cached mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting pathspec>=0.9.0
  Using cached pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting platformdirs>=2
  Using cached platformdirs-3.5.1-py3-none-any.whl (15 kB)
Collecting tomli>=1.1.0
  Using cached tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting black
  Using cached black-23.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.6 MB)
  Using cached black-22.12.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.6 MB)
Collecting typing-extensions>=3.10.0.0
  Using cached typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting deprecation<3.0,>=2.0
  Using cached deprecation-2.1.0-py2.py3-none-any.whl (11 kB)
Collecting elastic-transport<9,>=8
  Using cached elastic_transport-8.4.0-py3-none-any.whl (59 kB)
Collecting mccabe<0.8.0,>=0.7.0
  Using cached mccabe-0.7.0-py2.py3-none-any.whl (7.3 kB)
Collecting pycodestyle<2.11.0,>=2.10.0
  Using cached pycodestyle-2.10.0-py2.py3-none-any.whl (41 kB)
Collecting pyflakes<3.1.0,>=3.0.0
  Using cached pyflakes-3.0.1-py2.py3-none-any.whl (62 kB)
Collecting itsdangerous>=2.1.2
  Using cached itsdangerous-2.1.2-py3-none-any.whl (15 kB)
Collecting importlib-metadata>=3.6.0
  Using cached importlib_metadata-6.6.0-py3-none-any.whl (22 kB)
Collecting Jinja2>=3.1.2
  Using cached Jinja2-3.1.2-py3-none-any.whl (133 kB)
Collecting Werkzeug>=2.3.3
  Downloading Werkzeug-2.3.6-py3-none-any.whl (242 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 242.5/242.5 KB 11.8 MB/s eta 0:00:00
Collecting blinker>=1.6.2
  Using cached blinker-1.6.2-py3-none-any.whl (13 kB)
Collecting watchdog>=1.0.0
  Using cached watchdog-3.0.0-py3-none-manylinux2014_x86_64.whl (82 kB)
Collecting virtualenv>=20.10.0
  Using cached virtualenv-20.23.0-py3-none-any.whl (3.3 MB)
Collecting identify>=1.0.0
  Using cached identify-2.5.24-py2.py3-none-any.whl (98 kB)
Collecting nodeenv>=0.11.1
  Using cached nodeenv-1.8.0-py2.py3-none-any.whl (22 kB)
Collecting cfgv>=2.0.0
  Using cached cfgv-3.3.1-py2.py3-none-any.whl (7.3 kB)
Collecting astroid<=2.17.0-dev0,>=2.15.4
  Using cached astroid-2.15.5-py3-none-any.whl (278 kB)
Collecting dill>=0.2
  Using cached dill-0.3.6-py3-none-any.whl (110 kB)
Collecting tomlkit>=0.10.1
  Using cached tomlkit-0.11.8-py3-none-any.whl (35 kB)
Collecting iniconfig
  Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Collecting exceptiongroup>=1.0.0rc8
  Using cached exceptiongroup-1.1.1-py3-none-any.whl (14 kB)
Collecting pluggy<2.0,>=0.12
  Using cached pluggy-1.0.0-py2.py3-none-any.whl (13 kB)
Collecting coverage[toml]>=5.2.1
  Using cached coverage-7.2.7-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (228 kB)
Collecting pydot>=1.4.2
  Using cached pydot-1.4.2-py2.py3-none-any.whl (21 kB)
Collecting attrs>=21.4.0
  Using cached attrs-23.1.0-py3-none-any.whl (61 kB)
Collecting toml>=0.10.2
  Using cached toml-0.10.2-py2.py3-none-any.whl (16 kB)
Collecting networkx<3.2
  Using cached networkx-3.1-py3-none-any.whl (2.1 MB)
Collecting libcst==0.4.9
  Using cached libcst-0.4.9-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.8 MB)
Collecting ninja>=1.10.0.post2
  Using cached ninja-1.11.1-py2.py3-none-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (145 kB)
Collecting tabulate>=0.8.10
  Using cached tabulate-0.9.0-py3-none-any.whl (35 kB)
Collecting importlab>=0.8
  Using cached importlab-0.8-py2.py3-none-any.whl (21 kB)
Collecting typing-inspect>=0.4.0
  Using cached typing_inspect-0.9.0-py3-none-any.whl (8.8 kB)
Collecting ruamel.yaml.clib>=0.2.7
  Using cached ruamel.yaml.clib-0.2.7-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl (519 kB)
Collecting dparse>=0.6.2
  Using cached dparse-0.6.2-py3-none-any.whl (12 kB)
Collecting types-urllib3
  Using cached types_urllib3-1.26.25.13-py3-none-any.whl (15 kB)
Collecting wrapt<2,>=1.11
  Using cached wrapt-1.15.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (78 kB)
Collecting lazy-object-proxy>=1.4.0
  Using cached lazy_object_proxy-1.9.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (62 kB)
Collecting urllib3<3,>=1.21.1
  Using cached urllib3-1.26.16-py2.py3-none-any.whl (143 kB)
Collecting gitdb<5,>=4.0.1
  Using cached gitdb-4.0.10-py3-none-any.whl (62 kB)
Collecting googleapis-common-protos<2.0dev,>=1.56.2
  Using cached googleapis_common_protos-1.59.0-py2.py3-none-any.whl (223 kB)
Collecting grpcio-status<2.0dev,>=1.33.2
  Using cached grpcio_status-1.54.2-py3-none-any.whl (5.1 kB)
Collecting cachetools<6.0,>=2.0.0
  Using cached cachetools-5.3.1-py3-none-any.whl (9.3 kB)
Collecting pyasn1-modules>=0.2.1
  Using cached pyasn1_modules-0.3.0-py2.py3-none-any.whl (181 kB)
Collecting rsa<5,>=3.1.4
  Using cached rsa-4.9-py3-none-any.whl (34 kB)
Collecting google-crc32c<2.0dev,>=1.0
  Using cached google_crc32c-1.5.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (32 kB)
Collecting pyparsing!=3.0.0,!=3.0.1,!=3.0.2,!=3.0.3,<4,>=2.4.2
  Using cached pyparsing-3.0.9-py3-none-any.whl (98 kB)
Collecting zipp>=0.5
  Using cached zipp-3.15.0-py3-none-any.whl (6.8 kB)
Collecting MarkupSafe>=2.0
  Using cached MarkupSafe-2.1.3-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (25 kB)
Collecting pbr!=2.1.0,>=2.0.0
  Using cached pbr-5.11.1-py2.py3-none-any.whl (112 kB)
Collecting distlib<1,>=0.3.6
  Using cached distlib-0.3.6-py2.py3-none-any.whl (468 kB)
Collecting filelock<4,>=3.11
  Using cached filelock-3.12.0-py3-none-any.whl (10 kB)
Collecting pygments<3.0.0,>=2.13.0
  Using cached Pygments-2.15.1-py3-none-any.whl (1.1 MB)
Collecting markdown-it-py<3.0.0,>=2.2.0
  Using cached markdown_it_py-2.2.0-py3-none-any.whl (84 kB)
Collecting smmap<6,>=3.0.1
  Using cached smmap-5.0.0-py3-none-any.whl (24 kB)
Collecting grpcio-status<2.0dev,>=1.33.2
  Using cached grpcio_status-1.54.0-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.53.1-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.53.0-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.51.3-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.51.1-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.50.0-py3-none-any.whl (14 kB)
  Using cached grpcio_status-1.49.1-py3-none-any.whl (14 kB)
  Using cached grpcio_status-1.48.2-py3-none-any.whl (14 kB)
Collecting mdurl~=0.1
  Using cached mdurl-0.1.2-py3-none-any.whl (10.0 kB)
Collecting pyasn1<0.6.0,>=0.4.6
  Using cached pyasn1-0.5.0-py2.py3-none-any.whl (83 kB)
Building wheels for collected packages: slo-generator
  Building editable for slo-generator (pyproject.toml) ... done
  Created wheel for slo-generator: filename=slo_generator-2.3.4-0.editable-py2.py3-none-any.whl size=11267 sha256=5ab54a91b3a51626e893e819a0dbc722e3fb13a828e35a16d0e86e3ba6c93da8
  Stored in directory: /tmp/pip-ephem-wheel-cache-z9jht_al/wheels/9a/a5/f6/90bf32658c91b39293a48b6db71c6c9a9347e441daf11270ad
Successfully built slo-generator
Installing collected packages: types-urllib3, types-setuptools, types-PyYAML, types-python-dateutil, types-protobuf, ninja, distlib, zipp, wrapt, wheel, watchdog, urllib3, uritemplate, typing-extensions, types-requests, tomlkit, tomli, toml, tabulate, smmap, six, setuptools, ruamel.yaml.clib, pyyaml, pyparsing, pygments, pyflakes, pycodestyle, pyasn1, protobuf, prometheus-client, pluggy, platformdirs, pip, pbr, pathspec, networkx, mypy-extensions, mock, mdurl, mccabe, MarkupSafe, lazy-object-proxy, itsdangerous, isort, iniconfig, idna, identify, grpcio, google-crc32c, filelock, exceptiongroup, dill, coverage, click, charset-normalizer, cfgv, certifi, cachetools, blinker, attrs, Werkzeug, virtualenv, typing-inspect, stevedore, ruamel.yaml, rsa, retrying, requests, python-dateutil, pydot, pyasn1-modules, proto-plus, packaging, nodeenv, mypy, markdown-it-py, Jinja2, importlib-metadata, importlab, httplib2, gunicorn, googleapis-common-protos, google-resumable-media, gitdb, flake8, elastic-transport, black, astroid, slo-generator, rich, pytest, pylint, prometheus-http-client, pre-commit, libcst, grpcio-status, google-auth, GitPython, Flask, elasticsearch, dparse, deprecation, datadog, safety, pytype, pytest-cov, grpc-google-iam-v1, google-auth-httplib2, google-api-core, cloudevents, bandit, google-cloud-core, google-api-python-client, functions-framework, google-cloud-pubsub, google-cloud-monitoring, google-cloud-bigquery
  Attempting uninstall: setuptools
    Found existing installation: setuptools 58.1.0
    Uninstalling setuptools-58.1.0:
      Successfully uninstalled setuptools-58.1.0
  Attempting uninstall: pip
    Found existing installation: pip 22.0.4
    Uninstalling pip-22.0.4:
      Successfully uninstalled pip-22.0.4
Successfully installed Flask-2.3.2 GitPython-3.1.31 Jinja2-3.1.2 MarkupSafe-2.1.3 Werkzeug-2.3.6 astroid-2.15.5 attrs-23.1.0 bandit-1.7.5 black-22.12.0 blinker-1.6.2 cachetools-5.3.1 certifi-2023.5.7 cfgv-3.3.1 charset-normalizer-3.1.0 click-8.1.3 cloudevents-1.9.0 coverage-7.2.7 datadog-0.45.0 deprecation-2.1.0 dill-0.3.6 distlib-0.3.6 dparse-0.6.2 elastic-transport-8.4.0 elasticsearch-8.8.0 exceptiongroup-1.1.1 filelock-3.12.0 flake8-6.0.0 functions-framework-3.4.0 gitdb-4.0.10 google-api-core-2.11.0 google-api-python-client-1.12.11 google-auth-2.19.1 google-auth-httplib2-0.1.0 google-cloud-bigquery-2.34.4 google-cloud-core-2.3.2 google-cloud-monitoring-2.15.0 google-cloud-pubsub-1.7.2 google-crc32c-1.5.0 google-resumable-media-2.5.0 googleapis-common-protos-1.59.0 grpc-google-iam-v1-0.12.6 grpcio-1.54.2 grpcio-status-1.48.2 gunicorn-20.1.0 httplib2-0.22.0 identify-2.5.24 idna-3.4 importlab-0.8 importlib-metadata-6.6.0 iniconfig-2.0.0 isort-5.12.0 itsdangerous-2.1.2 lazy-object-proxy-1.9.0 libcst-0.4.9 markdown-it-py-2.2.0 mccabe-0.7.0 mdurl-0.1.2 mock-5.0.2 mypy-1.3.0 mypy-extensions-1.0.0 networkx-3.1 ninja-1.11.1 nodeenv-1.8.0 packaging-21.3 pathspec-0.11.1 pbr-5.11.1 pip-23.1.2 platformdirs-3.5.1 pluggy-1.0.0 pre-commit-3.3.2 prometheus-client-0.17.0 prometheus-http-client-1.0.0 proto-plus-1.22.2 protobuf-3.20.3 pyasn1-0.5.0 pyasn1-modules-0.3.0 pycodestyle-2.10.0 pydot-1.4.2 pyflakes-3.0.1 pygments-2.15.1 pylint-2.17.4 pyparsing-3.0.9 pytest-7.3.1 pytest-cov-4.1.0 python-dateutil-2.8.2 pytype-2023.6.2 pyyaml-6.0 requests-2.31.0 retrying-1.3.3 rich-13.4.1 rsa-4.9 ruamel.yaml-0.17.31 ruamel.yaml.clib-0.2.7 safety-2.3.5 setuptools-67.8.0 six-1.16.0 slo-generator-2.3.4 smmap-5.0.0 stevedore-5.1.0 tabulate-0.9.0 toml-0.10.2 tomli-2.0.1 tomlkit-0.11.8 types-PyYAML-6.0.12.10 types-protobuf-4.23.0.1 types-python-dateutil-2.8.19.13 types-requests-2.31.0.1 types-setuptools-67.8.0.0 types-urllib3-1.26.25.13 typing-extensions-4.6.3 typing-inspect-0.9.0 uritemplate-3.0.1 urllib3-1.26.16 virtualenv-20.23.0 watchdog-3.0.0 wheel-0.40.0 wrapt-1.15.0 zipp-3.15.0
(venv) user@workstation-la3rvj4l:/tmp/slo-generator$ pre-commit run
trim trailing whitespace.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
autoflake............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
black................................................(no files to check)Skipped
isort................................................(no files to check)Skipped
pylint...............................................(no files to check)Skipped
(venv) user@workstation-la3rvj4l:/tmp/slo-generator$ pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
autoflake................................................................Passed
flake8...................................................................Passed
black....................................................................Passed
isort....................................................................Passed
pylint...................................................................Passed
(venv) user@workstation-la3rvj4l:/tmp/slo-generator$ isort --version

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.12.0

(venv) user@workstation-la3rvj4l:/tmp/slo-generator$

So unfortunately I am unable to reproduce this behavior. Any chance you could test the exact same workflow and share the output?

@mveroone
Copy link
Contributor Author

mveroone commented Jun 9, 2023

Still the same.

I'm running a Debian 11 WSL2 instance, if that helps...

cd /tmp
git clone git@github.com:google/slo-generator.git
cd slo-generator/
python3 --version
python3 -m venv venv
source venv/bin/activate
make install
pre-commit run
pre-commit run --all-files
isort --version
Cloning into 'slo-generator'...
remote: Enumerating objects: 2443, done.
remote: Counting objects: 100% (361/361), done.
remote: Compressing objects: 100% (184/184), done.
remote: Total 2443 (delta 189), reused 330 (delta 175), pack-reused 2082
Receiving objects: 100% (2443/2443), 1.04 MiB | 2.07 MiB/s, done.
Resolving deltas: 100% (1511/1511), done.
Python 3.9.2
Cleaning up distutils stuff
rm -rf build
rm -rf dist
rm -rf MANIFEST
rm -rf *.egg-info
Cleaning up byte compiled python stuff
find . -type f -regex ".*\.py[co]$" -delete
Cleaning up doc builds
rm -rf docs/_build
rm -rf docs/api_modules
rm -rf docs/client_modules
Cleaning up test reports
rm -rf report/*
pip3 install -e ."[api, datadog, prometheus, elasticsearch, pubsub, cloud_monitoring, bigquery, dev]"
Obtaining file:///tmp/slo-generator
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Collecting python-dateutil
  Using cached python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
Collecting pyyaml
  Using cached PyYAML-6.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (661 kB)
Collecting click
  Using cached click-8.1.3-py3-none-any.whl (96 kB)
Collecting ruamel.yaml
  Downloading ruamel.yaml-0.17.31-py3-none-any.whl (112 kB)
     |████████████████████████████████| 112 kB 1.7 MB/s
Collecting setuptools>=65.5.1
  Using cached setuptools-67.8.0-py3-none-any.whl (1.1 MB)
Collecting google-cloud-monitoring<3
  Using cached google_cloud_monitoring-2.15.0-py2.py3-none-any.whl (323 kB)
Collecting google-api-python-client<2
  Using cached google_api_python_client-1.12.11-py2.py3-none-any.whl (62 kB)
Collecting google-cloud-pubsub<2
  Using cached google_cloud_pubsub-1.7.2-py2.py3-none-any.whl (144 kB)
Collecting elasticsearch
  Using cached elasticsearch-8.8.0-py3-none-any.whl (393 kB)
Collecting mock
  Using cached mock-5.0.2-py3-none-any.whl (30 kB)
Collecting pytype
  Downloading pytype-2023.6.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.9 MB)
     |████████████████████████████████| 3.9 MB 15.9 MB/s
Collecting mypy
  Using cached mypy-1.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (12.2 MB)
Collecting safety
  Using cached safety-2.3.5-py3-none-any.whl (57 kB)
Collecting types-setuptools
  Using cached types_setuptools-67.8.0.0-py3-none-any.whl (44 kB)
Collecting types-python-dateutil
  Using cached types_python_dateutil-2.8.19.13-py3-none-any.whl (9.2 kB)
Collecting types-requests
  Using cached types_requests-2.31.0.1-py3-none-any.whl (14 kB)
Collecting isort
  Using cached isort-5.12.0-py3-none-any.whl (91 kB)
Collecting pre-commit
  Using cached pre_commit-3.3.2-py2.py3-none-any.whl (202 kB)
Collecting flake8
  Using cached flake8-6.0.0-py2.py3-none-any.whl (57 kB)
Collecting pytest-cov
  Using cached pytest_cov-4.1.0-py3-none-any.whl (21 kB)
Collecting bandit
  Using cached bandit-1.7.5-py3-none-any.whl (123 kB)
Collecting pytest
  Using cached pytest-7.3.1-py3-none-any.whl (320 kB)
Collecting types-PyYAML
  Using cached types_PyYAML-6.0.12.10-py3-none-any.whl (14 kB)
Collecting types-protobuf
  Using cached types_protobuf-4.23.0.1-py3-none-any.whl (61 kB)
Collecting wheel
  Using cached wheel-0.40.0-py3-none-any.whl (64 kB)
Collecting black
  Using cached black-23.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.7 MB)
Collecting pip>=22.3
  Using cached pip-23.1.2-py3-none-any.whl (2.1 MB)
Collecting pylint
  Using cached pylint-2.17.4-py3-none-any.whl (536 kB)
Collecting prometheus-http-client
  Using cached prometheus_http_client-1.0.0-py2.py3-none-any.whl (21 kB)
Collecting prometheus-client
  Using cached prometheus_client-0.17.0-py3-none-any.whl (60 kB)
Collecting google-cloud-bigquery<3
  Using cached google_cloud_bigquery-2.34.4-py2.py3-none-any.whl (206 kB)
Collecting requests
  Using cached requests-2.31.0-py3-none-any.whl (62 kB)
Collecting Flask
  Using cached Flask-2.3.2-py3-none-any.whl (96 kB)
Collecting cloudevents
  Using cached cloudevents-1.9.0-py3-none-any.whl (47 kB)
Collecting functions-framework
  Using cached functions_framework-3.4.0-py3-none-any.whl (32 kB)
Collecting gunicorn
  Using cached gunicorn-20.1.0-py3-none-any.whl (79 kB)
Collecting retrying==1.3.3
  Using cached retrying-1.3.3.tar.gz (10 kB)
Collecting datadog
  Using cached datadog-0.45.0-py2.py3-none-any.whl (113 kB)
Collecting six>=1.7.0
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting google-api-core<3dev,>=1.21.0
  Using cached google_api_core-2.11.0-py3-none-any.whl (120 kB)
Collecting google-auth<3dev,>=1.16.0
  Using cached google_auth-2.19.1-py2.py3-none-any.whl (181 kB)
Collecting uritemplate<4dev,>=3.0.0
  Using cached uritemplate-3.0.1-py2.py3-none-any.whl (15 kB)
Collecting httplib2<1dev,>=0.15.0
  Using cached httplib2-0.22.0-py3-none-any.whl (96 kB)
Collecting google-auth-httplib2>=0.0.3
  Using cached google_auth_httplib2-0.1.0-py2.py3-none-any.whl (9.3 kB)
Collecting protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5
  Using cached protobuf-4.23.2-cp37-abi3-manylinux2014_x86_64.whl (304 kB)
Collecting googleapis-common-protos<2.0dev,>=1.56.2
  Using cached googleapis_common_protos-1.59.0-py2.py3-none-any.whl (223 kB)
Collecting urllib3<2.0
  Using cached urllib3-1.26.16-py2.py3-none-any.whl (143 kB)
Collecting pyasn1-modules>=0.2.1
  Using cached pyasn1_modules-0.3.0-py2.py3-none-any.whl (181 kB)
Collecting rsa<5,>=3.1.4
  Using cached rsa-4.9-py3-none-any.whl (34 kB)
Collecting cachetools<6.0,>=2.0.0
  Using cached cachetools-5.3.1-py3-none-any.whl (9.3 kB)
Collecting protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5
  Using cached protobuf-3.20.3-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.0 MB)
Collecting proto-plus<2.0.0dev,>=1.15.0
  Using cached proto_plus-1.22.2-py3-none-any.whl (47 kB)
Collecting grpcio<2.0dev,>=1.38.1
  Using cached grpcio-1.54.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.1 MB)
Collecting google-resumable-media<3.0dev,>=0.6.0
  Using cached google_resumable_media-2.5.0-py2.py3-none-any.whl (77 kB)
Collecting google-cloud-core<3.0.0dev,>=1.4.1
  Using cached google_cloud_core-2.3.2-py2.py3-none-any.whl (29 kB)
Collecting packaging<22.0dev,>=14.3
  Using cached packaging-21.3-py3-none-any.whl (40 kB)
Collecting grpcio-status<2.0dev,>=1.33.2
  Using cached grpcio_status-1.54.2-py3-none-any.whl (5.1 kB)
Collecting grpc-google-iam-v1<0.13dev,>=0.12.3
  Using cached grpc_google_iam_v1-0.12.6-py2.py3-none-any.whl (26 kB)
Collecting google-crc32c<2.0dev,>=1.0
  Using cached google_crc32c-1.5.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (32 kB)
Collecting grpcio-status<2.0dev,>=1.33.2
  Using cached grpcio_status-1.54.0-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.53.1-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.53.0-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.51.3-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.51.1-py3-none-any.whl (5.1 kB)
  Using cached grpcio_status-1.50.0-py3-none-any.whl (14 kB)
  Using cached grpcio_status-1.49.1-py3-none-any.whl (14 kB)
  Using cached grpcio_status-1.48.2-py3-none-any.whl (14 kB)
Collecting pyparsing!=3.0.0,!=3.0.1,!=3.0.2,!=3.0.3,<4,>=2.4.2
  Using cached pyparsing-3.0.9-py3-none-any.whl (98 kB)
Collecting pyasn1<0.6.0,>=0.4.6
  Using cached pyasn1-0.5.0-py2.py3-none-any.whl (83 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2023.5.7-py3-none-any.whl (156 kB)
Collecting charset-normalizer<4,>=2
  Using cached charset_normalizer-3.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (199 kB)
Collecting idna<4,>=2.5
  Using cached idna-3.4-py3-none-any.whl (61 kB)
Collecting GitPython>=1.0.1
  Using cached GitPython-3.1.31-py3-none-any.whl (184 kB)
Collecting stevedore>=1.20.0
  Using cached stevedore-5.1.0-py3-none-any.whl (49 kB)
Collecting rich
  Downloading rich-13.4.1-py3-none-any.whl (239 kB)
     |████████████████████████████████| 239 kB 6.1 MB/s
Collecting gitdb<5,>=4.0.1
  Using cached gitdb-4.0.10-py3-none-any.whl (62 kB)
Collecting smmap<6,>=3.0.1
  Using cached smmap-5.0.0-py3-none-any.whl (24 kB)
Collecting pbr!=2.1.0,>=2.0.0
  Using cached pbr-5.11.1-py2.py3-none-any.whl (112 kB)
Collecting black
  Using cached black-23.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.6 MB)
  Using cached black-22.12.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.6 MB)
Collecting pathspec>=0.9.0
  Using cached pathspec-0.11.1-py3-none-any.whl (29 kB)
Collecting mypy-extensions>=0.4.3
  Using cached mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting tomli>=1.1.0
  Using cached tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting typing-extensions>=3.10.0.0
  Using cached typing_extensions-4.6.3-py3-none-any.whl (31 kB)
Collecting platformdirs>=2
  Using cached platformdirs-3.5.1-py3-none-any.whl (15 kB)
Collecting deprecation<3.0,>=2.0
  Using cached deprecation-2.1.0-py2.py3-none-any.whl (11 kB)
Collecting elastic-transport<9,>=8
  Using cached elastic_transport-8.4.0-py3-none-any.whl (59 kB)
Collecting pycodestyle<2.11.0,>=2.10.0
  Using cached pycodestyle-2.10.0-py2.py3-none-any.whl (41 kB)
Collecting pyflakes<3.1.0,>=3.0.0
  Using cached pyflakes-3.0.1-py2.py3-none-any.whl (62 kB)
Collecting mccabe<0.8.0,>=0.7.0
  Using cached mccabe-0.7.0-py2.py3-none-any.whl (7.3 kB)
Collecting importlib-metadata>=3.6.0
  Using cached importlib_metadata-6.6.0-py3-none-any.whl (22 kB)
Collecting blinker>=1.6.2
  Using cached blinker-1.6.2-py3-none-any.whl (13 kB)
Collecting itsdangerous>=2.1.2
  Using cached itsdangerous-2.1.2-py3-none-any.whl (15 kB)
Collecting Jinja2>=3.1.2
  Using cached Jinja2-3.1.2-py3-none-any.whl (133 kB)
Collecting Werkzeug>=2.3.3
  Downloading Werkzeug-2.3.6-py3-none-any.whl (242 kB)
     |████████████████████████████████| 242 kB 59.7 MB/s
Collecting zipp>=0.5
  Using cached zipp-3.15.0-py3-none-any.whl (6.8 kB)
Collecting MarkupSafe>=2.0
  Using cached MarkupSafe-2.1.3-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (25 kB)
Collecting watchdog>=1.0.0
  Using cached watchdog-3.0.0-py3-none-manylinux2014_x86_64.whl (82 kB)
Collecting nodeenv>=0.11.1
  Using cached nodeenv-1.8.0-py2.py3-none-any.whl (22 kB)
Collecting cfgv>=2.0.0
  Using cached cfgv-3.3.1-py2.py3-none-any.whl (7.3 kB)
Collecting virtualenv>=20.10.0
  Using cached virtualenv-20.23.0-py3-none-any.whl (3.3 MB)
Collecting identify>=1.0.0
  Using cached identify-2.5.24-py2.py3-none-any.whl (98 kB)
Collecting filelock<4,>=3.11
  Using cached filelock-3.12.0-py3-none-any.whl (10 kB)
Collecting distlib<1,>=0.3.6
  Using cached distlib-0.3.6-py2.py3-none-any.whl (468 kB)
Collecting astroid<=2.17.0-dev0,>=2.15.4
  Using cached astroid-2.15.5-py3-none-any.whl (278 kB)
Collecting dill>=0.2
  Using cached dill-0.3.6-py3-none-any.whl (110 kB)
Collecting tomlkit>=0.10.1
  Using cached tomlkit-0.11.8-py3-none-any.whl (35 kB)
Collecting wrapt<2,>=1.11
  Using cached wrapt-1.15.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (78 kB)
Collecting lazy-object-proxy>=1.4.0
  Using cached lazy_object_proxy-1.9.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (62 kB)
Collecting pluggy<2.0,>=0.12
  Using cached pluggy-1.0.0-py2.py3-none-any.whl (13 kB)
Collecting iniconfig
  Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Collecting exceptiongroup>=1.0.0rc8
  Using cached exceptiongroup-1.1.1-py3-none-any.whl (14 kB)
Collecting coverage[toml]>=5.2.1
  Using cached coverage-7.2.7-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (228 kB)
Collecting ninja>=1.10.0.post2
  Using cached ninja-1.11.1-py2.py3-none-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (145 kB)
Collecting attrs>=21.4.0
  Using cached attrs-23.1.0-py3-none-any.whl (61 kB)
Collecting importlab>=0.8
  Using cached importlab-0.8-py2.py3-none-any.whl (21 kB)
Collecting tabulate>=0.8.10
  Using cached tabulate-0.9.0-py3-none-any.whl (35 kB)
Collecting networkx<3.2
  Using cached networkx-3.1-py3-none-any.whl (2.1 MB)
Collecting toml>=0.10.2
  Using cached toml-0.10.2-py2.py3-none-any.whl (16 kB)
Collecting pydot>=1.4.2
  Using cached pydot-1.4.2-py2.py3-none-any.whl (21 kB)
Collecting libcst==0.4.9
  Using cached libcst-0.4.9-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.8 MB)
Collecting typing-inspect>=0.4.0
  Using cached typing_inspect-0.9.0-py3-none-any.whl (8.8 kB)
Collecting markdown-it-py<3.0.0,>=2.2.0
  Using cached markdown_it_py-2.2.0-py3-none-any.whl (84 kB)
Collecting pygments<3.0.0,>=2.13.0
  Using cached Pygments-2.15.1-py3-none-any.whl (1.1 MB)
Collecting mdurl~=0.1
  Using cached mdurl-0.1.2-py3-none-any.whl (10.0 kB)
Collecting ruamel.yaml.clib>=0.2.7
  Using cached ruamel.yaml.clib-0.2.7-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl (519 kB)
Collecting dparse>=0.6.2
  Using cached dparse-0.6.2-py3-none-any.whl (12 kB)
Collecting types-urllib3
  Using cached types_urllib3-1.26.25.13-py3-none-any.whl (15 kB)
Using legacy 'setup.py install' for retrying, since package 'wheel' is not installed.
Installing collected packages: pyasn1, urllib3, six, rsa, pyparsing, pyasn1-modules, protobuf, idna, charset-normalizer, certifi, cachetools, zipp, typing-extensions, smmap, requests, packaging, mypy-extensions, mdurl, MarkupSafe, grpcio, googleapis-common-protos, google-auth, wrapt, Werkzeug, typing-inspect, tomli, toml, setuptools, ruamel.yaml.clib, pyyaml, pygments, pluggy, platformdirs, pbr, networkx, markdown-it-py, lazy-object-proxy, Jinja2, itsdangerous, iniconfig, importlib-metadata, httplib2, grpcio-status, google-crc32c, google-api-core, gitdb, filelock, exceptiongroup, distlib, deprecation, coverage, click, blinker, watchdog, virtualenv, uritemplate, types-urllib3, tomlkit, tabulate, stevedore, ruamel.yaml, rich, python-dateutil, pytest, pyflakes, pydot, pycodestyle, proto-plus, pathspec, nodeenv, ninja, mccabe, libcst, isort, importlab, identify, gunicorn, grpc-google-iam-v1, google-resumable-media, google-cloud-core, google-auth-httplib2, GitPython, Flask, elastic-transport, dparse, dill, cloudevents, cfgv, attrs, astroid, wheel, types-setuptools, types-requests, types-PyYAML, types-python-dateutil, types-protobuf, slo-generator, safety, retrying, pytype, pytest-cov, pylint, prometheus-http-client, prometheus-client, pre-commit, pip, mypy, mock, google-cloud-pubsub, google-cloud-monitoring, google-cloud-bigquery, google-api-python-client, functions-framework, flake8, elasticsearch, datadog, black, bandit
  Attempting uninstall: setuptools
    Found existing installation: setuptools 44.1.1
    Uninstalling setuptools-44.1.1:
      Successfully uninstalled setuptools-44.1.1
  Running setup.py develop for slo-generator
    Running setup.py install for retrying ... done
  Attempting uninstall: pip
    Found existing installation: pip 20.3.4
    Uninstalling pip-20.3.4:
      Successfully uninstalled pip-20.3.4
Successfully installed Flask-2.3.2 GitPython-3.1.31 Jinja2-3.1.2 MarkupSafe-2.1.3 Werkzeug-2.3.6 astroid-2.15.5 attrs-23.1.0 bandit-1.7.5 black-22.12.0 blinker-1.6.2 cachetools-5.3.1 certifi-2023.5.7 cfgv-3.3.1 charset-normalizer-3.1.0 click-8.1.3 cloudevents-1.9.0 coverage-7.2.7 datadog-0.45.0 deprecation-2.1.0 dill-0.3.6 distlib-0.3.6 dparse-0.6.2 elastic-transport-8.4.0 elasticsearch-8.8.0 exceptiongroup-1.1.1 filelock-3.12.0 flake8-6.0.0 functions-framework-3.4.0 gitdb-4.0.10 google-api-core-2.11.0 google-api-python-client-1.12.11 google-auth-2.19.1 google-auth-httplib2-0.1.0 google-cloud-bigquery-2.34.4 google-cloud-core-2.3.2 google-cloud-monitoring-2.15.0 google-cloud-pubsub-1.7.2 google-crc32c-1.5.0 google-resumable-media-2.5.0 googleapis-common-protos-1.59.0 grpc-google-iam-v1-0.12.6 grpcio-1.54.2 grpcio-status-1.48.2 gunicorn-20.1.0 httplib2-0.22.0 identify-2.5.24 idna-3.4 importlab-0.8 importlib-metadata-6.6.0 iniconfig-2.0.0 isort-5.12.0 itsdangerous-2.1.2 lazy-object-proxy-1.9.0 libcst-0.4.9 markdown-it-py-2.2.0 mccabe-0.7.0 mdurl-0.1.2 mock-5.0.2 mypy-1.3.0 mypy-extensions-1.0.0 networkx-3.1 ninja-1.11.1 nodeenv-1.8.0 packaging-21.3 pathspec-0.11.1 pbr-5.11.1 pip-23.1.2 platformdirs-3.5.1 pluggy-1.0.0 pre-commit-3.3.2 prometheus-client-0.17.0 prometheus-http-client-1.0.0 proto-plus-1.22.2 protobuf-3.20.3 pyasn1-0.5.0 pyasn1-modules-0.3.0 pycodestyle-2.10.0 pydot-1.4.2 pyflakes-3.0.1 pygments-2.15.1 pylint-2.17.4 pyparsing-3.0.9 pytest-7.3.1 pytest-cov-4.1.0 python-dateutil-2.8.2 pytype-2023.6.2 pyyaml-6.0 requests-2.31.0 retrying-1.3.3 rich-13.4.1 rsa-4.9 ruamel.yaml-0.17.31 ruamel.yaml.clib-0.2.7 safety-2.3.5 setuptools-67.8.0 six-1.16.0 slo-generator smmap-5.0.0 stevedore-5.1.0 tabulate-0.9.0 toml-0.10.2 tomli-2.0.1 tomlkit-0.11.8 types-PyYAML-6.0.12.10 types-protobuf-4.23.0.1 types-python-dateutil-2.8.19.13 types-requests-2.31.0.1 types-setuptools-67.8.0.0 types-urllib3-1.26.25.13 typing-extensions-4.6.3 typing-inspect-0.9.0 uritemplate-3.0.1 urllib3-1.26.16 virtualenv-20.23.0 watchdog-3.0.0 wheel-0.40.0 wrapt-1.15.0 zipp-3.15.0
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/mveroone/.cache/pre-commit/repoa6vlf55_
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-1919ir3t/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-1919ir3t/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/mveroone/.cache/pre-commit/pre-commit.log
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/mveroone/.cache/pre-commit/repoa6vlf55_
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-zc9f17bh/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-zc9f17bh/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/mveroone/.cache/pre-commit/pre-commit.log

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.12.0

@lvaylet
Copy link
Collaborator

lvaylet commented Jun 9, 2023

Weird. I am also running Debian 11 inside a dedicated Cloud Workstation:

(venv) user@workstation-la3rvj4l:/tmp/slo-generator$ cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

I tested the same workflow with Python 3.9.2 in order to match your config as closely as possible. I got the same result, with no errors 🤔.

@mveroone
Copy link
Contributor Author

Is there any risk of updating that package, though ?
I get that there's a mystery we would both like to solve, but in the meantime, this prevents me from commiting to any other branch =/ (including my Splunk PR)

@bkamin29
Copy link

bkamin29 commented Jun 12, 2023 •
edited

Hello,
Same issue than @mveroone on my side :

OCO/google_slo_generator/slo-generator  master ✔                                                                                                                                  93d19h  
▶ pre-commit run
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /Users/benjamin/.cache/pre-commit/repo2wd3r9hi
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error
      
      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/private/var/folders/vm/bx_p7skx4rsfnzrms7ykfmxw0000gq/T/pip-build-env-j58xl6y3/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/private/var/folders/vm/bx_p7skx4rsfnzrms7ykfmxw0000gq/T/pip-build-env-j58xl6y3/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
          
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.
    
    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /Users/benjamin/.cache/pre-commit/pre-commit.log
(venv)

I'm running on macOS M1, Python 3.9.16

@bkamin29
Copy link

Issue seems to be related to PyCQA/isort#2078

@lvaylet
Copy link
Collaborator

lvaylet commented Jun 13, 2023

OK let's move forward. I still don't understand why this Poetry bug affects us, as we do not use Poetry. This being said, I agree there is not a big risk associated with bumping the version of this dependency.

@lvaylet lvaylet merged commit 5542a06 into google:master Jun 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mveroone @lvaylet @bkamin29