Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsuccessful attempt to shim toSorted support into node 14 for jest tests. #8216

Closed
wants to merge 1 commit into from

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Feb 2, 2024

Summary

Addresses issue:

Relevant technical choices

Although this attempt was unsuccessful it can serve as a base for future exploration of the topic in question in #7571.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@benbowler benbowler changed the title Attempt to shim toSorted support into node 14 for jest tests. Unsuccessful attempt to shim toSorted support into node 14 for jest tests. Feb 2, 2024
@benbowler benbowler force-pushed the benbowler/7571-shim-toSorted-for-jest branch from 3ac3cb7 to 9084c12 Compare February 9, 2024 11:12
@benbowler
Copy link
Collaborator Author

Closing as the better approach is to use core-js.

@benbowler benbowler closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant