Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cleanup after PR closed #1201

Merged
merged 5 commits into from
Mar 3, 2020
Merged

Conversation

aaemnnosttv
Copy link
Collaborator

@aaemnnosttv aaemnnosttv commented Mar 3, 2020

Summary

Follow up to PR #1172

This PR makes a few small changes to fix the GitHub Action workflow that runs when a PR is closed.

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@aaemnnosttv aaemnnosttv marked this pull request as ready for review March 3, 2020 15:15
@aaemnnosttv
Copy link
Collaborator Author

@adamsilverstein there seems to be an issue with commits not able to be pushed to the wiki repo now, which is odd because I'm sure this was working before. How did you have your PAT set before?

Left is the last run before the PR was merged (run) - Right is a recent run that failed (run)
image

remote: Permission to google/site-kit-wp.wiki.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/google/site-kit-wp.wiki/': The requested URL returned error: 403
##[error]Process completed with exit code 128.

According to the checkout action readme, it looks like we'll need to add a personal token back 😞

${{ github.token }} is scoped to the current repository, so if you want to checkout a different repository that is private you will need to provide your own PAT.

Copy link
Collaborator

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this.

@felixarntz felixarntz merged commit 90b07c4 into develop Mar 3, 2020
@felixarntz felixarntz deleted the update/1172-cleanup-after-pr branch March 3, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants