Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions to build PRs and develop, cleanup closed PRs. #1172
Add actions to build PRs and develop, cleanup closed PRs. #1172
Changes from 2 commits
44874b4
2907354
ba06fd3
5d2f2de
4a43389
fcd7b1c
caed4bc
6f0fdf2
b3612da
36f4963
93a438c
72c853e
fec6cca
30ed8e4
64bbc86
d048a32
d1073c8
0545345
0cee859
0d5da4a
b4cac9e
5f2a962
1c22b82
1e24d8a
1051d69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we build the PR on any tags/and on
master
it would save us (usually @felixarntz) having to build the production ZIP by hand on a Mac. Having the CI generate our builds instead of us doing it manually is way nicer, so I filed #1196 to chat about that and extend this later 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This runs on pushes to
develop
, but doesn't remove the file. Will the upload overwrite this one based on theref
being the branch name (develop
) over the commit hash?If so that seems fine, but just wanna make sure this isn't going to spawn a lot of ZIP files 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated zip files are renamed as
google-site-kit.zip
andgoogle-site-kit-dev.zip
so yes 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: the github.ref in this case is
refs/heads/develop
(so that is where the zips wind up being stored)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really scope of this PR, but the scripts in
package.json
are a bit inconsistent between how they work for production vs development. E.g.build:dev
includes a call tobuild:static
whilebuild:production
andbuild:test
don't.I'll open a small separate issue with this.