Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Optional #672

Merged
merged 1 commit into from Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,8 @@
#### 3.2.0-dev

* Deprecate `Optional`. With the introduction of non-null by default in Dart
SDK 2.12, existing users should migrate to non-nullable types. This type
will be removed in Quiver 4.0.0.
* Expose `TreeIterator` for iterating `TreeSet` instead of using
`BidirectionalIterator`.
* Require Dart 2.17
Expand Down
4 changes: 3 additions & 1 deletion lib/src/core/optional.dart
Expand Up @@ -24,7 +24,9 @@ import 'dart:collection';
///
/// With the introduction of non-null by default in Dart SDK 2.12, developers
/// should avoid adding more uses of this type. Existing users should migrate
/// away from the `Optional` type to types marked nullable: `T?`.
/// away from the `Optional` type to types marked nullable: `T?`. This type
/// will be removed in Quiver 4.0.0.
@Deprecated('Migrate to a non-nullable type. Will be removed in 4.0.0')
class Optional<T> extends IterableBase<T> {
/// Constructs an empty Optional.
const Optional.absent() : _value = null;
Expand Down
1 change: 1 addition & 0 deletions test/core/optional_test.dart
Expand Up @@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// ignore_for_file: deprecated_member_use_from_same_package
library quiver.core.optional_test;

import 'package:quiver/src/core/optional.dart';
Expand Down