Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-go] Initial integration #4479

Merged
merged 1 commit into from Sep 25, 2020
Merged

Conversation

codyoss
Copy link
Contributor

@codyoss codyoss commented Sep 24, 2020

No description provided.

@inferno-chromium inferno-chromium merged commit 5434e70 into google:master Sep 25, 2020
@codyoss codyoss deleted the gcg branch September 25, 2020 16:56
@AdamKorcz
Copy link
Collaborator

Hey @codyoss.
Respectfully and politely, it would be nice to acknowledge the PR (#3824) I previously did - which found a bug that was reported and fixed (googleapis/google-cloud-go#2196) - where I integrated the project, as I can see you use my work in your commit googleapis/google-cloud-go#2909

I am not too bothered about attribution although it certainly has its merits, but since there is an integration reward I think it would be fair to attribute the original author.

@inferno-chromium
Copy link
Collaborator

Hey @codyoss.
Respectfully and politely, it would be nice to acknowledge the PR (#3824) I previously did - which found a bug that was reported and fixed (googleapis/google-cloud-go#2196) - where I integrated the project, as I can see you use my work in your commit googleapis/google-cloud-go#2909

I am not too bothered about attribution although it certainly has its merits, but since there is an integration reward I think it would be fair to attribute the original author.

@AdamKorcz - since you proposed the original PR to google-cloud-go project, we would gladly consider you for integration reward.
@codyoss - you would be still the owner for this pipeline since we always encourage actual project devs to own the fuzzing integration, get access to bugs, and fix them. if you have any concerns about Adam's reward, feel free to reach out to me directly over email.

@codyoss
Copy link
Contributor Author

codyoss commented Oct 5, 2020

@inferno-chromium All sounds good to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants