Fix enum lookup in annotation proxies #685
Conversation
Before, this would take the `toString()` of the KSType, but that's wrong because then you have something like `AnnotationRetention.valueOf("kotlin.annotation.AnnotationRetention.RUNTIME")`, which obviously won't work. This unpacks the short name from the `KSType` directly so that it actually looks up just `RUNTIME` in the given example.
|
Weirdly I can't repro this issue, but it does repro if you use the current KSP 1.5.31 impl in this PR square/moshi#1393 |
| returnType.getDeclaredMethod("valueOf", String::class.java) | ||
| .invoke( | ||
| null, | ||
| if (this is KSType) { |
There was a problem hiding this comment.
(Related discussion; Not for this PR)
Without the type checking it would result in the following error, where the type of this is TestEnum, rather than a KSType.
https://github.com/google/ksp/runs/3911397835#step:9:729
@neetopia Does the need of type checking here indicate a discrepancy in implementations of annotation value? In other words, shouldn't it always be KSType?
There was a problem hiding this comment.
For example, this was one of the difference among the implementations of .class and sources.
It could also be the reason why it's only reproducible with KSP 1.5.31-1.0.0; The toString()s of class instance and KSType are different.
Before, this would take the
toString()of the KSType, but that's wrong because then you have something likeAnnotationRetention.valueOf("kotlin.annotation.AnnotationRetention.RUNTIME"), which obviously won't work. This unpacks the short name from theKSTypedirectly so that it actually looks up justRUNTIMEin the given example.