Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hierarchy in KSP API sealed (attempt 2) #1592

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Nov 8, 2023

  1. Make hierarchy in KSP API sealed

    Interfaces that were sealed: KSAnnotated, KSDeclarationContainer,
    KSReferenceElement, KSModifierListOwner, KSPropertyAccessor,
    KSDeclaration and PlatformInfo
    lukellmann committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    137e17e View commit details
    Browse the repository at this point in the history
  2. Fix compilation

    Abstract implementation classes that inherited from now sealed types
    have those supertypes removed and replace overridden with open members.
    Additional casts had to be introduced in a few places.
    
    A few when statements had to be made exhaustive (by specifying all
    cases) because they now operate on subjects with a sealed type.
    lukellmann committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6c64ba8 View commit details
    Browse the repository at this point in the history
  3. Seal KSNode

    KSNodeDescriptorImpl, KSNodeJavaImpl and KSNodeKtImpl were removed
    because they were unused but inherited from the now sealed KSNode.
    lukellmann committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c37900c View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Configuration menu
    Copy the full SHA
    cda8056 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Merge branch 'main' into sealed-hierarchies

    # Conflicts:
    #	common-util/src/main/kotlin/com/google/devtools/ksp/common/IncrementalContextBase.kt
    #	kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/AbstractKSDeclarationImpl.kt
    #	kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSTypeAliasImpl.kt
    lukellmann committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    407ce39 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'main' into sealed-hierarchies

    # Conflicts:
    #	kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/AbstractKSDeclarationImpl.kt
    lukellmann committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    550eae8 View commit details
    Browse the repository at this point in the history