Block other compiler plugins by default #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and dropping support of other compiler plugins in KSP's task.
ting-yuan
force-pushed
the
block-others
branch
from
62e20a7
to
b7802f9
Compare
neetopia
approved these changes
Sep 27, 2022
| @@ -59,7 +59,7 @@ class PlaygroundIT { | |||
| val gradleRunner = GradleRunner.create().withProjectDir(project.root) | |||
|
|
|||
| File(project.root, "workload/build.gradle.kts") | |||
| .appendText("\nksp {\n blockOtherCompilerPlugins = true\n}\n") | |||
| .appendText("\nksp {\n blockOtherCompilerPlugins = false\n}\n") | |||
There was a problem hiding this comment.
I'd like to deprecate the flag gradually. The default becomes true effectively. Let's not break blockOtherCompilerPlugins = false too soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and deprecate
blockOtherPlugins.Fixes #897
There's still no real test yet because no built-in plugin runs before
AnalysisHandlerExtension; The existing test only checks whether it builds.