Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually look up in scope when annotation argument type is nested annotation. #1099

Merged
merged 1 commit into from Sep 13, 2022

Conversation

neetopia
Copy link
Collaborator

@neetopia neetopia commented Sep 9, 2022

The root cause might be in compiler, as the compiler returns a NotFoundClasses for nested annotation types.

Copy link
Collaborator

@ting-yuan ting-yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, does getClassDeclarationByName work with nested / anonymous classes?

@neetopia
Copy link
Collaborator Author

anonymous does not have a FQN so it does not matter. added test cases for getClassDeclarationByName

@neetopia neetopia merged commit 35a12d6 into google:main Sep 13, 2022
@neetopia neetopia deleted the nested-class-default-value branch September 13, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSuchElementException when getting a default argument of the inner annotation type
2 participants