Seal KSNode

KSNodeDescriptorImpl, KSNodeJavaImpl and KSNodeKtImpl were removed because they were unused but inherited from the now sealed KSNode.
google · Nov 3, 2023 · 431bc8f · 431bc8f
1 parent 82af0bb
commit 431bc8f
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 35 deletions.
diff --git a/api/api.base b/api/api.base
@@ -401,7 +401,7 @@ package com.google.devtools.ksp.symbol {
     method @NonNull public String getShortName();
   }
 
-  public interface KSNode {
+  public sealed interface KSNode {
     method public <D, R> R accept(@NonNull com.google.devtools.ksp.symbol.KSVisitor<D,R> visitor, D data);
     method @NonNull public com.google.devtools.ksp.symbol.Location getLocation();
     method @NonNull public com.google.devtools.ksp.symbol.Origin getOrigin();

diff --git a/api/src/main/kotlin/com/google/devtools/ksp/symbol/KSNode.kt b/api/src/main/kotlin/com/google/devtools/ksp/symbol/KSNode.kt
@@ -19,7 +19,7 @@ package com.google.devtools.ksp.symbol
 /**
  * Base class of every visitable program elements.
  */
-interface KSNode {
+sealed interface KSNode {
     val origin: Origin
     val location: Location
     val parent: KSNode?

diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt
@@ -627,6 +627,11 @@ class ResolverImpl(
                     resolverContext = resolverContext
                         .childForClassOrPackage(resolveJavaDeclaration(e.psi) as ClassDescriptor, JavaClassImpl(e.psi))
                 }
+                is KSClassDeclaration, is KSFunctionDeclaration, is KSPropertyDeclaration, is KSTypeAlias,
+                is KSTypeParameter, is KSFile, is KSPropertyGetter, is KSPropertySetter, is KSTypeArgument,
+                is KSTypeReference, is KSValueArgument, is KSValueParameter, is KSAnnotation, is KSCallableReference,
+                is KSClassifierReference, is KSDefNonNullReference, is KSDynamicReference, is KSParenthesizedReference,
+                -> Unit
             }
         }
         return if (javaType is JavaArrayTypeImpl)

diff --git a/...plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSNodeDescriptorImpl.kt b/...plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSNodeDescriptorImpl.kt
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/java/KSNodeJavaImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/java/KSNodeJavaImpl.kt
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSNodeKtImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSNodeKtImpl.kt