go: update module, various cleanup #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
|
Oh, we will also need to update to Go 1.21 for this to work. |
JeffFaer
requested changes
Jan 12, 2024
|
Hey! Sorry for the slow review on this. My email filters weren't set up correctly, so I just hadn't even noticed this PR. This should be fixed moving forward Thanks for these clean ups! |
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
JeffFaer
approved these changes
Jan 12, 2024
JeffFaer
added a commit
that referenced
this pull request
Feb 6, 2024
It looks like GitHub actions only use go 1.20 by default, so anyone using keep-sorted via the GitHub action pre-commit would need to separately install go 1.21. It looks like pre-commit can do that for us automatically. See #18 (comment) for more details Tested in a child PR #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I hope the PR is okay in this form, otherwise I can also cherry-pick in different PRs if you like. :)