Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JsonConverter]: Support generators with constructor arguments #1374

Closed
wants to merge 1 commit into from

Conversation

phuongvt
Copy link

Support Issue: Can't custom JsonConverter with constructor arguments [#1373]

Support Issue: Can't custom JsonConverter with constructor arguments google#1373
Copy link

google-cla bot commented Nov 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@phuongvt phuongvt closed this Nov 18, 2023
@o-nnerb
Copy link

o-nnerb commented Jan 16, 2024

@phuongvt why did you closed this? It's very helpful

@phuongvt
Copy link
Author

@o-nnerb because this is my first time creating PR on github, I see @google-cla failed message.

Therefore I close this issue to set up my account correctly and open a new issue here #1375

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@o-nnerb
Copy link

o-nnerb commented Jan 17, 2024

@phuongvt thanks for the clarification! I'm very excited to include this modification into my projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants