Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializing enums explicitly references types unless nullable (issue … #1146

Merged
merged 4 commits into from Jun 25, 2022
Merged

Serializing enums explicitly references types unless nullable (issue … #1146

merged 4 commits into from Jun 25, 2022

Commits on May 31, 2022

  1. Fix serialization of non-nullable enums using _$xxxEnumMap 

    Before this change, serializing non-nullable enums in a subtype was incorrectly producing nullable string types.

For example, serializing a class member of type Map<enum, String> produced a type Map<String?, dynamic> where Map<String, dynamic> should have been produced.

Nullable enums should still produce nullable types, eg. serializing List<enum?> should produce List<String?>

fixes 1145
    @ssabdb
    ssabdb committed May 31, 2022
    Copy the full SHA
    2a4fa02 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Merge branch 'google:master' into master

    @ssabdb
    ssabdb committed Jun 4, 2022
    Copy the full SHA
    ea2adda View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2022

  1. Fix test annotations (google#1160)

    @kevmoo @ssabdb
    kevmoo authored and ssabdb committed Jun 19, 2022
    Copy the full SHA
    691c522 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Fix serialization of non-nullable enums using _$xxxEnumMap 

    Before this change, serializing non-nullable enums in a subtype was incorrectly producing nullable string types.

For example, serializing a class member of type Map<enum, String> produced a type Map<String?, dynamic> where Map<String, dynamic> should have been produced.

Nullable enums should still produce nullable types, eg. serializing List<enum?> should produce List<String?>

fixes 1145
    @ssabdb
    ssabdb committed Jun 24, 2022
    Copy the full SHA
    5f1f712 View commit details
    Browse the repository at this point in the history