New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JsonConverter(converters) option #1135
Conversation
I had to separate ClassConfig and JsonSerializable for this (because ClassConfig receives DartObjects for the converters but JsonSerializable receives a JsonConverter). Hopefully that's alright. |
Ha! We'll start by seeing if the tests pass. 😁 |
…dart into add-json-converter-option
The CI just wanted a dependency_overrides for the annotation 😄 |
b7d29ce
to
058bcab
Compare
…elGit/json_serializable into add-json-converter-option
I'm not quite sure how to fix that last CI error One test seems to complain if I don't update the readme with 4.6.0 links. But the markdown checked complains that 4.6.0 links are 404 (which is logical since it isn't published yet) |
ignore the markdown errors. That's expected when things are revved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
This implements what is described here #1072 (comment) (assuming this is desirable)
That should simplify a bit the work of having to reuse a few JsonConverter over and over by allowing folks to make a custom reusable annotation or write things like:
fixes #1072